Skip to content

Commit 64bc39a

Browse files
author
Ron Petrusha
authored
Merge pull request #6405 from dotnet/master
Update live with current master
2 parents 6064507 + e8a2f09 commit 64bc39a

File tree

9 files changed

+126
-145
lines changed

9 files changed

+126
-145
lines changed

docs/core/docker/building-net-docker-images.md

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,17 @@ Latest versions of each variant:
7878

7979
* This .NET Core Docker sample demonstrates a best practice pattern for [building Docker images for .NET Core apps for production.](https://github.com/dotnet/dotnet-docker/tree/master/samples/dotnetapp)
8080

81+
## Forward the request scheme and original IP address
82+
83+
Proxy servers, load balancers, and other network appliances often obscure information about a request before it reaches the containerized app:
84+
85+
* When HTTPS requests are proxied over HTTP, the original scheme (HTTPS) is lost and must be forwarded in a header.
86+
* Because an app receives a request from the proxy and not its true source on the Internet or corporate network, the original client IP address must also be forwarded in a header.
87+
88+
This information may be important in request processing, for example in redirects, authentication, link generation, policy evaluation, and client geolocation.
89+
90+
To forward the scheme and original IP address to a containerized ASP.NET Core app, use Forwarded Headers Middleware. For more information, see [Configure ASP.NET Core to work with proxy servers and load balancers](/aspnet/core/host-and-deploy/proxy-load-balancer).
91+
8192
## Your first ASP.NET Core Docker app
8293

8394
For this tutorial, lets use an ASP.NET Core Docker sample application for the app we want to dockerize. This ASP.NET Core Docker sample application demonstrates a best practice pattern for building Docker images for ASP.NET Core apps for production. The sample works with both Linux and Windows containers.
@@ -253,7 +264,6 @@ Congratulations! you have just:
253264
> * Built and ran the sample with Docker for Linux containers
254265
> * Built and ran the sample with Docker for Windows containers
255266
256-
257267
**Next Steps**
258268

259269
Here are some next steps you can take:

docs/core/versions/selection.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ The process for selecting an SDK version is:
4747
1. `dotnet` uses the SDK specified in the first *global.json* found.
4848
1. `dotnet` uses the latest installed SDK if no *global.json* is found.
4949

50-
You can learn more about selecting an SDK version in the [matching rules](../tools/global-json.md) section of the topic on *global.json*.
50+
You can learn more about selecting an SDK version in the [Matching rules](../tools/global-json.md#matching-rules) section of the topic on *global.json*.
5151

5252
## Target Framework Monikers define build time APIs
5353

docs/csharp/programming-guide/classes-and-structs/fields.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ A *field* is a variable of any type that is declared directly in a [class](../..
3535

3636
A field can optionally be declared [static](../../../csharp/language-reference/keywords/static.md). This makes the field available to callers at any time, even if no instance of the class exists. For more information, see [Static Classes and Static Class Members](../../../csharp/programming-guide/classes-and-structs/static-classes-and-static-class-members.md).
3737

38-
A field can be declared [readonly](../../../csharp/language-reference/keywords/readonly.md). A read-only field can only be assigned a value during initialization or in a constructor. A `static``readonly` field is very similar to a constant, except that the C# compiler does not have access to the value of a static read-only field at compile time, only at run time. For more information, see [Constants](../../../csharp/programming-guide/classes-and-structs/constants.md).
38+
A field can be declared [readonly](../../../csharp/language-reference/keywords/readonly.md). A read-only field can only be assigned a value during initialization or in a constructor. A `static readonly` field is very similar to a constant, except that the C# compiler does not have access to the value of a static read-only field at compile time, only at run time. For more information, see [Constants](../../../csharp/programming-guide/classes-and-structs/constants.md).
3939

4040
## C# Language Specification
4141
[!INCLUDE[CSharplangspec](~/includes/csharplangspec-md.md)]

docs/framework/configure-apps/file-schema/network/proxy-element-network-settings.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ Defines a proxy server.
4242
|`autoDetect`|Specifies whether the proxy is automatically detected. The default value is `unspecified`.|
4343
|`bypassonlocal`|Specifies whether the proxy is bypassed for local resources. Local resources include the local server (`http://localhost`, `http://loopback`, or `http://127.0.0.1`) and a URI without a period (`http://webserver`). The default value is `unspecified`.|
4444
|`proxyaddress`|Specifies the proxy URI to use.|
45-
|`scriptLocation`|Specifies the location of the configuration script.|
45+
|`scriptLocation`|Specifies the location of the configuration script. Do not use the `bypassonlocal` attribute with this attribute. |
4646
|`usesystemdefault`|Specifies whether to use Internet Explorer proxy settings. If set to `true`, subsequent attributes will override Internet Explorer proxy settings. The default value is `unspecified`.|
4747

4848
### Child Elements
@@ -61,7 +61,7 @@ Defines a proxy server.
6161

6262
The value for the `proxyaddress` attribute should be a well-formed Uniform Resource Indicator (URI).
6363

64-
The `scriptLocation` attribute refers to the automatic detection of proxy configuration scripts. The <xref:System.Net.WebProxy> class will attempt to locate a configuration script (usually named Wpad.dat) when the **Use automatic configuration script** option is selected in Internet Explorer.
64+
The `scriptLocation` attribute refers to the automatic detection of proxy configuration scripts. The <xref:System.Net.WebProxy> class will attempt to locate a configuration script (usually named Wpad.dat) when the **Use automatic configuration script** option is selected in Internet Explorer. If `bypassonlocal` is set to any value, `scriptLocation` is ignored.
6565

6666
Use the `usesystemdefault` attribute for .NET Framework version 1.1 applications that are migrating to version 2.0.
6767

docs/framework/data/adonet/ef/language-reference/entity-sql-reference.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ Equality and inequality are defined for any object type that has identity, such
4848
|[< (Less Than)](less-than-entity-sql.md)|Compares two expressions to determine whether the left expression has a value less than the right expression.|
4949
|[<= (Less Than or Equal To)](less-than-or-equal-to-entity-sql.md)|Compares two expressions to determine whether the left expression has a value less than or equal to the right expression.|
5050
|[\[NOT\] BETWEEN](between-entity-sql.md)|Determines whether an expression results in a value in a specified range.|
51-
|[!= (Not Equal To)](not-equal-to-entity-sql.md)|Compares two expressions to determine whether the left expression isn't equal to the right expression.|
51+
|[\!= (Not Equal To)](not-equal-to-entity-sql.md)|Compares two expressions to determine whether the left expression isn't equal to the right expression.|
5252
|[\[NOT\] LIKE](like-entity-sql.md)|Determines whether a specific character string matches a specified pattern.|
5353

5454
## Logical and case expression operators
@@ -58,7 +58,7 @@ Logical operators test for the truth of a condition. The CASE expression evaluat
5858
|Operator|Description|
5959
|--------------|-----------------|
6060
|[&& (Logical AND)](and-entity-sql.md)|Logical AND.|
61-
|[! (Logical NOT)](not-entity-sql.md)|Logical NOT.|
61+
|[\! (Logical NOT)](not-entity-sql.md)|Logical NOT.|
6262
|[&#124;&#124; (Logical OR)](or-entity-sql.md)|Logical OR.|
6363
|[CASE](case-entity-sql.md)|Evaluates a set of Boolean expressions to determine the result.|
6464
|[THEN](then-entity-sql.md)|The result of a [WHEN](http://msdn.microsoft.com/library/6233fe9f-00b0-460e-8372-64e138a5f998) clause when it evaluates to true.|

docs/fsharp/get-started/get-started-visual-studio.md

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ It is in this function that we call the `square` function with an argument of `1
4141

4242
## Running your code
4343

44-
You can run the code and see results by pressing **ctrl-f5**. This will run the program without debugging and allows you to see the results. Alternatively, you can choose the **Debug** top-level menu item in Visual Studio and choose **Start Without Debugging**.
44+
You can run the code and see results by pressing **Ctrl**+**F5**. This runs the program without debugging and allows you to see the results. Alternatively, you can choose the **Debug** top-level menu item in Visual Studio and choose **Start Without Debugging**.
4545

4646
You should now see the following printed to the console window that Visual Studio popped up:
4747

@@ -56,7 +56,8 @@ Congratulations! You've created your first F# project in Visual Studio, written
5656
If you haven't already, check out the [Tour of F#](../tour.md), which covers some of the core features of the F# language. It will give you an overview of some of the capabilities of F#, and provide ample code samples that you can copy into Visual Studio and run. There are also some great external resources you can use, showcased in the [F# Guide](../index.md).
5757

5858
## See also
59-
[Tour of F#](../tour.md)
60-
[F# language reference](../language-reference/index.md)
61-
[Type inference](../language-reference/type-inference.md)
62-
[Symbol and operator reference](../language-reference/symbol-and-operator-reference/index.md)
59+
60+
- [Tour of F#](../tour.md)
61+
- [F# language reference](../language-reference/index.md)
62+
- [Type inference](../language-reference/type-inference.md)
63+
- [Symbol and operator reference](../language-reference/symbol-and-operator-reference/index.md)

docs/machine-learning/tutorials/sentiment-analysis.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ Classification tasks are frequently one of the following types:
100100

101101
1. Download the [WikiPedia detox-250-line-data.tsv](https://github.com/dotnet/machinelearning/blob/master/test/data/wikipedia-detox-250-line-data.tsv) and the [wikipedia-detox-250-line-test.tsv](https://github.com/dotnet/machinelearning/blob/master/test/data/wikipedia-detox-250-line-test.tsv) data sets and save them to the *Data* folder previously created. The first dataset trains the machine learning model and the second can be used to evaluate how accurate your model is.
102102

103-
2. In Solution Explorer, right-click each of the \*.tsv files and select **Properties**. Under **Advanced**, change the value of **Copy to Output Directory** to **Always**.
103+
2. In Solution Explorer, right-click each of the \*.tsv files and select **Properties**. Under **Advanced**, change the value of **Copy to Output Directory** to **Copy if newer**.
104104

105105
### Create classes and define paths
106106

0 commit comments

Comments
 (0)