Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global.json documentation #2902

Closed
nguerrera opened this issue Aug 14, 2017 · 10 comments
Closed

global.json documentation #2902

nguerrera opened this issue Aug 14, 2017 · 10 comments
Assignees
Labels
⌚ Not Triaged Not triaged

Comments

@nguerrera
Copy link

nguerrera commented Aug 14, 2017

From @jaredpar on July 17, 2017 21:19

Where can I find documentation on global.json? This is the only public documentation I could find:

https://docs.microsoft.com/en-us/dotnet/core/tools/global-json

Unfortunately it doesn't answer the questions I have about the sdk.versions property. In particular:

  • What are the matching rules? Say I put 1.0 but 2.0 is available. Will 2.0 be chosen or will an error occur?
  • Can I put in version ranges?
  • Is there globbing support?

Also of interest is the version of the SDK that comes installed with Visual Studio. Does that version change on every update, preview, etc ... of VS? Worried about how updates to VS will interact with restrictions that I add in this file.

Copied from original issue: dotnet/sdk#1421

edit by @mairaw: added info Docs below


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

@nguerrera
Copy link
Author

From @jaredpar on July 18, 2017 18:35

CC @rainersigwald, @nguerrera, @dsplaisted

@nguerrera
Copy link
Author

From @livarcocc on July 18, 2017 23:40

@mairaw can we work on documentation for this? We changed the policy in 2.0, it would be good to do an all up write up on this file.

@nguerrera
Copy link
Author

From @jaredpar on July 19, 2017 15:7

@livarcocc can we get the details posted here while waiting for doc? Need to understand how this works before we can adopt in our repos.

@nguerrera
Copy link
Author

From @mairaw on August 12, 2017 7:21

Sorry, I missed this mention earlier. Yes, we can improve the docs. Doc issues can be filed at https://github.com/dotnet/docs/issues. Can I have more info on what needs to be done @livarcocc @nguerrera? I don't know what the change was or the answer to @jaredpar's questions, unfortunately. Should we move this to our repo?

@nguerrera
Copy link
Author

What are the matching rules? Say I put 1.0 but 2.0 is available. Will 2.0 be chosen or will an error occur?

Prior to dotnet 2.0, the matching rule was that if no exact match was found, then latest would be used. https://github.com/dotnet/core-setup/issues/2334

In 2.0, the rules are described in this PR's description: dotnet/core-setup#2621. However, in the desktop msbuild/VS case, the error cases listed there are actually currently fallbacks to the 1.1 SDK in the MSBuild folder due to the problem described in dotnet/sdk#1470 (comment)

Can I put in version ranges?

No

Is there globbing support?

No

Also of interest is the version of the SDK that comes installed with Visual Studio. Does that version change on every update, preview, etc ... of VS? Worried about how updates to VS will interact with restrictions that I add in this file.

Yes, it does change.

@nguerrera
Copy link
Author

Tagging @johnbeisner.

@BillWagner BillWagner removed the P3 label Mar 8, 2018
@mairaw
Copy link
Contributor

mairaw commented Mar 20, 2018

I'm working on this right now. One behavior I've observed is that if I specify a patch version that is greater than the latest installed version, latest is used.

e.g. if I specify 2.1.4 and the latest version I have is 2.1.300-preview1-008174, latest is used (something like roll backward along patch). By design?

/cc @KathleenDollard

@mairaw mairaw modified the milestones: Sprint 132 (2/24/18 - 3/16/18), Sprint 133 (3/19/18 - 4/06/18) Mar 20, 2018
@dsplaisted
Copy link
Member

@mairaw That sounds like this issue: https://github.com/dotnet/core-setup/issues/3805

@mairaw
Copy link
Contributor

mairaw commented Mar 20, 2018

That's correct @dsplaisted!

@mairaw
Copy link
Contributor

mairaw commented Mar 20, 2018

I've read the info @nguerrera about the VS/MSBuild case and it's not super clear to me what happens when with the multiple possible combinations (VS versions earlier than 15.3 and later, SDK 1.1, SDK 2.0, etc.)

Can someone please summarize that please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⌚ Not Triaged Not triaged
Projects
None yet
Development

No branches or pull requests

5 participants