Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong starting version for the breaking change #29718

Closed
mariozski opened this issue Jun 3, 2022 · 5 comments · Fixed by #29747 or #29753
Closed

Wrong starting version for the breaking change #29718

mariozski opened this issue Jun 3, 2022 · 5 comments · Fixed by #29747 or #29753

Comments

@mariozski
Copy link

The documentation page mentions the breaking change was introduced in 6.0.6, while the formatting of logs have already been changes in 6.0.5.


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

@dotnet-bot dotnet-bot added the ⌚ Not Triaged Not triaged label Jun 3, 2022
@mariozski mariozski changed the title Wront starting version for the breaking change Wrong starting version for the breaking change Jun 3, 2022
@gewarren
Copy link
Contributor

gewarren commented Jun 6, 2022

@mariozski The change to use the JSON formatter is documented here: dotnet/dotnet-docker#3699. The breaking change article that you created this issue for is when a change was made to leave the formatter environment variable unset, and that occurred in 6.0.6, according to my info. Let me know if you still think that's incorrect.

I will go ahead and add a link to the release notes page from https://docs.microsoft.com/dotnet/core/compatibility/6.0#containers.

@mariozski
Copy link
Author

@gewarren yes, the change to JSON was initially introduced with .NET 6 release. That is correct. Though it seems that revert of that change happened in 6.0.5 and not in 6.0.6. I've deployed recently 6.0.5 to check it and it uses the old formatter, not the JSON one.

That's how the logs were formatted on the asp.net 6.0.4 container image:
image

That's how the logs are displayed on the asp.net 6.0.5 container image:
image

@dotnet-bot dotnet-bot added ⌚ Not Triaged Not triaged and removed ⌚ Not Triaged Not triaged labels Jun 7, 2022
@gewarren
Copy link
Contributor

gewarren commented Jun 7, 2022

@mthalman Should I change the version to 6.0.5?

@gewarren gewarren reopened this Jun 7, 2022
@gewarren gewarren self-assigned this Jun 7, 2022
@dotnet-bot dotnet-bot removed the ⌚ Not Triaged Not triaged label Jun 7, 2022
@mthalman
Copy link
Member

mthalman commented Jun 7, 2022

@gewarren - Yes, it should be 6.0.5. See dotnet/announcements#216 (it says May 2022 servicing which is 6.0.5).

@gewarren
Copy link
Contributor

gewarren commented Jun 7, 2022

Thanks - I updated #29243 too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants