Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 'Severity' section in Option Format #38540

Closed
mavasani opened this issue Dec 1, 2023 · 0 comments · Fixed by #39570
Closed

Update 'Severity' section in Option Format #38540

mavasani opened this issue Dec 1, 2023 · 0 comments · Fixed by #39570
Assignees
Labels
dotnet-fundamentals/svc in-pr This issue will be closed (fixed) by an active pull request. 📌 seQUESTered Identifies that an issue has been imported into Quest. ⌚ Not Triaged Not triaged

Comments

@mavasani
Copy link
Contributor

mavasani commented Dec 1, 2023

Type of issue

Outdated article

Description

See dotnet/roslyn#52991. Before dotnet/roslyn#69844 got merged, the severity specified in option_name = option_value:severity was only respected in the IDE live analysis, not on command line builds. The documentation correctly mentions this information.

However, with the above change, the severity specified in option_name = option_value:severity will get respected on build as well. Note that to prevent any breaking changes, this functionality is not enabled by default, unless the AnalysisLevel or AnalysisLevelStyle is greater than or equals 9.0 or set to preview on .NET 8 SDK and also in the future when we release .NET 9 SDK and users migrate their project to net9 without setting any AnalysisLevel value - for net9 TFM we would default AnalysisLevel to 9.0 and hence this feature will get turned on by default.

Page URL

https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/language-rules?source=docs

Content source URL

https://github.com/dotnet/docs/blob/main/docs/fundamentals/code-analysis/style-rules/language-rules.md

Document Version Independent Id

012968d3-07d2-5c37-fa3d-e3561eff8681

Article author

@gewarren

Metadata

  • ID: 4f19aa22-56d1-ff22-a410-e5e0b6a80e6d
  • Product: dotnet-fundamentals

Associated WorkItem - 206397

@dotnet-bot dotnet-bot added the ⌚ Not Triaged Not triaged label Dec 1, 2023
@gewarren gewarren self-assigned this Jan 30, 2024
@gewarren gewarren added the 🗺️ reQUEST Triggers an issue to be imported into Quest. label Feb 2, 2024
@github-actions github-actions bot added 📌 seQUESTered Identifies that an issue has been imported into Quest. and removed 🗺️ reQUEST Triggers an issue to be imported into Quest. labels Feb 2, 2024
@gewarren gewarren moved this from 🔖 Ready to 🏗 In progress in dotnet/docs February 2024 sprint Feb 16, 2024
@dotnet-policy-service dotnet-policy-service bot added the in-pr This issue will be closed (fixed) by an active pull request. label Feb 16, 2024
@gewarren gewarren moved this from 🏗 In progress to 👀 In review in dotnet/docs February 2024 sprint Feb 16, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in dotnet/docs February 2024 sprint Feb 16, 2024
@dotnet-bot dotnet-bot added ⌚ Not Triaged Not triaged and removed ⌚ Not Triaged Not triaged labels Feb 16, 2024
@BillWagner BillWagner added 📌 seQUESTered Identifies that an issue has been imported into Quest. and removed 📌 seQUESTered Identifies that an issue has been imported into Quest. labels Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dotnet-fundamentals/svc in-pr This issue will be closed (fixed) by an active pull request. 📌 seQUESTered Identifies that an issue has been imported into Quest. ⌚ Not Triaged Not triaged
Projects
No open projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

4 participants