Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versioning recommendation for AssemblyVersion is not compatible with Windows Installer (MSI) #9202

Closed
MarketKernel opened this issue Nov 23, 2018 · 4 comments
Labels
dotnet/svc won't fix Issues that were closed as part of automated backlog grooming

Comments

@MarketKernel
Copy link

MarketKernel commented Nov 23, 2018

This recommendation:

✔️ CONSIDER only including a major version in the AssemblyVersion.

Is not compatible with Windows Installer (MSI). When reinstalling the program, MSI leaves the old libraries if AssemblyVersion has not been changed (AssemblyFileVersion is ignored by MSI).

Is there any solution of this problem?
https://guides.github.com/features/mastering-markdown/


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

Copy link

There's still a general problem with de-centralized assembly loaders like Powershell. If cmdlet A relies on functionality from version 1.1.3 of some assembly, but cmdlet B runs first and loads version 1.1.0 the assembly, then cmdlet A may fail to run. For a traditional EXE a binding redirect would work, but one can't edit powershell's config like that.

@tdykstra tdykstra added P2 and removed ⌚ Not Triaged Not triaged labels Sep 9, 2019
Copy link
Contributor

@MarketKernel I would suggest moving awai from MSI and towards Squirrel.Windows instead. I believe this is what Microsoft Teams uses, based on observing the file layout of Teams. Let me know if this solves your problem. There are so many issues with MSIs, that I do not think MSIs should dictate best practices.

Copy link
Contributor

@shueybubbles It's not clear to me if you meant to reply to @MarketKernel, but there is general discussion in the PowerShell reposistory about fixing the psd1 module manifest format, among other issues. With PowerShell Core, the transitive failure is somewhat fixable through AssemblyLoadContext. The downside is that until .NET Core 3 arrives, you cannot unload those context assemblies.

@PRMerger8 PRMerger8 added the Pri2 label Jan 16, 2021
@dotnet-bot dotnet-bot added the won't fix Issues that were closed as part of automated backlog grooming label Jan 25, 2021
@dotnet-bot
Copy link
Contributor

This issue has been closed as part of the issue backlog grooming process outlined in #22351.

That automated process may have closed some issues that should be addressed. If you think this is one of them, reopen it with a comment explaining why. Tag the @dotnet/docs team for visibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dotnet/svc won't fix Issues that were closed as part of automated backlog grooming
Projects
None yet
Development

No branches or pull requests

8 participants