Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor run-tests.ps1 to not install .NET Core #1077

Closed
MichaelSimons opened this issue Apr 22, 2019 · 2 comments
Closed

Refactor run-tests.ps1 to not install .NET Core #1077

MichaelSimons opened this issue Apr 22, 2019 · 2 comments

Comments

@MichaelSimons
Copy link
Member

It should not be necessary to install .NET Core within run-tests.ps1. This logic is not robust and will fail the builds periodically. Investigate other options such as building/running the tests within a container to eliminate this flakiness.

@mthalman
Copy link
Member

This is specific to Windows which requires that tests be run directly on the build agent instead of a container.

@mthalman
Copy link
Member

mthalman commented Mar 1, 2023

This wouldn't be necessary once dotnet/docker-tools#159 is fixed. This hasn't been causing any functional issues so I think it makes sense to not do any work here and just wait for the Windows nested container support.

@mthalman mthalman closed this as not planned Won't fix, can't repro, duplicate, stale Mar 1, 2023
@github-project-automation github-project-automation bot moved this from Needs Review to Done in .NET Docker Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants