Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up duplicated .NET 8.0 Bookworm Dockerfile entries in manifest #4575

Open
mthalman opened this issue Apr 19, 2023 · 0 comments
Open

Clean up duplicated .NET 8.0 Bookworm Dockerfile entries in manifest #4575

mthalman opened this issue Apr 19, 2023 · 0 comments

Comments

@mthalman
Copy link
Member

Now that #4536 has been implemented, we no longer need to have duplicated Dockerfile entries between two different sets of shared tags, for the .NET 8.0 Bookworm Dockerfiles. Previous to #4536, these needed to be duplicated so that, for example, the 8.0/bookworm-slim/amd64 can be associated with two different sets of shared tags:

  • latest, 8.0-preview, 8.0.0-preview.1
  • 8.0-preview-bookworm-slim, 8.0.0-preview.1-bookworm-slim

But now that Windows Dockerfiles are no longer included, these two sets of tags can be merged into one. This means the Bookworm Dockerfile entries don't need to be duplicated.

These changes don't apply to runtime-deps. Those entries are already implemented this way because Windows was never included there to begin with. Taking runtime as an example, what this means is that this whole section can be removed:

dotnet-docker/manifest.json

Lines 1947 to 1990 in 3bbd0b1

{
"id": "bookworm-slim",
"productVersion": "$(dotnet|8.0|product-version)",
"sharedTags": {
"$(dotnet|8.0|product-version)-bookworm-slim": {},
"8.0-preview-bookworm-slim": {}
},
"platforms": [
{
"buildArgs": {
"REPO": "$(Repo:runtime-deps)"
},
"dockerfile": "src/runtime/8.0/bookworm-slim/amd64",
"dockerfileTemplate": "eng/dockerfile-templates/runtime/Dockerfile.linux",
"os": "linux",
"osVersion": "bookworm-slim",
"tags": {}
},
{
"architecture": "arm",
"buildArgs": {
"REPO": "$(Repo:runtime-deps)"
},
"dockerfile": "src/runtime/8.0/bookworm-slim/arm32v7",
"dockerfileTemplate": "eng/dockerfile-templates/runtime/Dockerfile.linux",
"os": "linux",
"osVersion": "bookworm-slim",
"tags": {},
"variant": "v7"
},
{
"architecture": "arm64",
"buildArgs": {
"REPO": "$(Repo:runtime-deps)"
},
"dockerfile": "src/runtime/8.0/bookworm-slim/arm64v8",
"dockerfileTemplate": "eng/dockerfile-templates/runtime/Dockerfile.linux",
"os": "linux",
"osVersion": "bookworm-slim",
"tags": {},
"variant": "v8"
}
]
},

And its shared tags here:

dotnet-docker/manifest.json

Lines 1951 to 1952 in 3bbd0b1

"$(dotnet|8.0|product-version)-bookworm-slim": {},
"8.0-preview-bookworm-slim": {}

Can be moved to be included here:

dotnet-docker/manifest.json

Lines 1897 to 1900 in 3bbd0b1

"sharedTags": {
"$(dotnet|8.0|product-version)": {},
"8.0-preview": {}
},

This would be applied for runtime, aspnet, and sdk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

1 participant