You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The test is a [Fact], and therefore runs once per leg but uses only one base image, the multi-platform image, which is Debian. The Dockerfile should be amended to support multiple different images and the test should be amended to test across supported operating systems like the other sample tests.
[Triage]
The Dockerfile is meant to be a sample and the 8.0 tag was chosen for simplicity. Modifying the Dockerfile too drastically to support different test environments isn't really the approach we want. It's just a matter of making sure the Dockerfile can be built.
It's not necessary to provide a Windows-compatible Dockerfile as the main intent of the sample is to demonstrate a multi-project solution and how those get composed with a Dockerfile.
Looking at the VerifyComplexAppSample test, there are two concerns:
The
complexapp
sample Dockerfile uses the multi-platform tags and therefore won't build on Windows in .NET 8 due to Switch multi-platform tags to Linux only #4492:dotnet-docker/samples/complexapp/Dockerfile
Lines 1 to 3 in c09ce8b
The test is a
[Fact]
, and therefore runs once per leg but uses only one base image, the multi-platform image, which is Debian. The Dockerfile should be amended to support multiple different images and the test should be amended to test across supported operating systems like the other sample tests.dotnet-docker/tests/Microsoft.DotNet.Docker.Tests/SampleImageTests.cs
Lines 92 to 93 in c09ce8b
The text was updated successfully, but these errors were encountered: