Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make VerifyComplexAppSample Test a [Theory] #4873

Closed
lbussell opened this issue Sep 14, 2023 · 1 comment
Closed

Make VerifyComplexAppSample Test a [Theory] #4873

lbussell opened this issue Sep 14, 2023 · 1 comment

Comments

@lbussell
Copy link
Contributor

Looking at the VerifyComplexAppSample test, there are two concerns:

  1. The complexapp sample Dockerfile uses the multi-platform tags and therefore won't build on Windows in .NET 8 due to Switch multi-platform tags to Linux only #4492:

    # https://hub.docker.com/_/microsoft-dotnet
    FROM mcr.microsoft.com/dotnet/sdk:8.0 AS build
    WORKDIR /source

  2. The test is a [Fact], and therefore runs once per leg but uses only one base image, the multi-platform image, which is Debian. The Dockerfile should be amended to support multiple different images and the test should be amended to test across supported operating systems like the other sample tests.

    [Fact]
    public void VerifyComplexAppSample()

@mthalman
Copy link
Member

[Triage]
The Dockerfile is meant to be a sample and the 8.0 tag was chosen for simplicity. Modifying the Dockerfile too drastically to support different test environments isn't really the approach we want. It's just a matter of making sure the Dockerfile can be built.

It's not necessary to provide a Windows-compatible Dockerfile as the main intent of the sample is to demonstrate a multi-project solution and how those get composed with a Dockerfile.

@mthalman mthalman closed this as not planned Won't fix, can't repro, duplicate, stale Sep 20, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Done in .NET Docker Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants