Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing tags for .NET Monitor #5932

Closed
jander-msft opened this issue Sep 30, 2024 · 1 comment
Closed

Missing tags for .NET Monitor #5932

jander-msft opened this issue Sep 30, 2024 · 1 comment

Comments

@jander-msft
Copy link
Member

As identified in #5878 (comment), the .NET Monitor tag pattern is different than the .NET Aspire tag pattern.

.NET Monitor Tags

.NET Monitor tag pattern for 8.x and lower is:

  • <major>.<minor>.<patch>-<distro>-<arch>
  • <major>.<minor>.<patch>-<distro>
  • <major>.<minor>.<patch>
  • <major>.<minor>-<distro>-<arch>
  • <major>.<minor>-<distro>
  • <major>.<minor>
  • <major>-<distro>-<arch>
  • <major>-<distro>
  • <major>

.NET Monitor tag pattern for 9+ is:

  • <major>.<minor>.<patch>-<arch>
  • <major>.<minor>.<patch>
  • <major>.<minor>-<arch>
  • <major>.<minor>
  • <major>

The tag pattern is simpler compared to 8.x and lower since only a single distro is offered in .NET Monitor 9 and higher.

.NET Aspire Tags

.NET Aspire tag pattern is:

  • <major>.<minor>.<patch>-<arch>
  • <major>.<minor>.<patch>
  • <major>.<minor>-<arch>
  • <major>.<minor>
  • <major>-<arch>
  • <major>

Missing .NET Monitor Tags Compared to .NET Aspire

Compared to .NET Aspire, it appears that .NET Monitor is missing the following tags:

  • 9.x and higher: <major>-<arch>
  • 8.x and lower: <major>-<arch> and <major>.<minor>-<arch>

Other Observations

The main .NET product also does not have <major>.<minor>-<arch> tags. The .NET Monitor product largely mimicked the main .NET product tagging pattern, hence the lack of this tag.

Proposed Changes

For consistency among the appliance-style images, I propose the following changes:

  • Add <major>-<arch> and <major>.<minor>-<arch> to .NET Monitor 8.x
  • Add <major>-<arch> to .NET Monitor 9.x

The team should also consider whether runtime-deps/runtime/aspnet/sdk images should have <major>.<minor>-<arch> convenience tags as well.

@lbussell
Copy link
Contributor

[Triage] After some discussion, we decided that arch-specific tags provide little value for appliance-style images, so we should not create additional tags to resolve this discrepancy between .NET monitor and aspire-dashboard images. Instead, we should open a second issue with a proposal to remove arch-specific tags from appliance images. That issue should include updating the supported tags documentation for appliance images, and should also call out any discrepancies between tagging patterns for appliance style images.

Related: #5918

@lbussell lbussell closed this as not planned Won't fix, can't repro, duplicate, stale Sep 30, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in .NET Docker Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants