Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build and test infra to support internal release builds #5277

Merged
merged 2 commits into from
Sep 6, 2023

Conversation

jander-msft
Copy link
Member

@jander-msft jander-msft commented Sep 6, 2023

Summary
  • Setup private feed usage in the TPN job so it can acquire internal build builds
  • Change dotnetbuilds internal container token to be passed via environment to avoid escaping/splitting and use the non-based64 encoded variant
  • Convert the IncludeDotnetCli convenience to an AdditionalDotNetPackage so that it may consume the AdditionalDotNetPackageFeed list.

Validation build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2261376&view=results

Release Notes Entry

@ghost ghost added the needs-review label Sep 6, 2023
schmittjoseph
schmittjoseph previously approved these changes Sep 6, 2023
@ghost ghost removed the needs-review label Sep 6, 2023
@ghost ghost removed the needs-review label Sep 6, 2023
@jander-msft jander-msft merged commit f878acd into dotnet:main Sep 6, 2023
26 checks passed
@jander-msft jander-msft deleted the internal-release-fixes branch September 6, 2023 22:11
@jander-msft
Copy link
Member Author

/backport to release/8.x

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Started backporting to release/8.x: https://github.com/dotnet/dotnet-monitor/actions/runs/6102931201

jander-msft added a commit that referenced this pull request Sep 6, 2023
…5278)

Co-authored-by: Justin Anderson <jander-msft@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants