Skip to content

Commit 4b9bbd2

Browse files
committed
Use SqlClient 4.4.0-* to workaround "SqlClient fails with netcoreapp2.0 on Win7/Server2008"
- https://github.com/dotnet/corefx/issues/18406 - Revert when `$(CoreFxVersion)` is upgraded to `4.4.0-*`
1 parent 9d9c29b commit 4b9bbd2

File tree

2 files changed

+12
-2
lines changed

2 files changed

+12
-2
lines changed

src/EFCore.SqlServer/EFCore.SqlServer.csproj

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,12 @@
1717
<ProjectReference Include="..\EFCore.Relational\EFCore.Relational.csproj" />
1818
</ItemGroup>
1919
<ItemGroup>
20-
<PackageReference Include="System.Data.SqlClient" Version="$(CoreFxVersion)" />
20+
<!--
21+
* Use 4.4.0-* instead of $(CoreFxVersion) to workaround "SqlClient fails with netcoreapp2.0 on Win7/Server2008"
22+
* https://github.com/dotnet/corefx/issues/18406
23+
* Revert when $(CoreFxVersion) is upgraded to 4.4.0-*
24+
-->
25+
<PackageReference Include="System.Data.SqlClient" Version="4.4.0-*" />
2126
</ItemGroup>
2227
<ItemGroup Condition="'$(TargetFramework)' == 'netstandard1.3'">
2328
<PackageReference Include="System.Threading.Thread" Version="$(CoreFxVersion)" />

test/EFCore.Benchmarks/EFCore.Benchmarks.csproj

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,12 @@
88
<ItemGroup>
99
<PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="$(AspNetCoreVersion)" />
1010
<PackageReference Include="Microsoft.Extensions.Configuration.EnvironmentVariables" Version="$(AspNetCoreVersion)" />
11-
<PackageReference Include="System.Data.SqlClient" Version="$(CoreFxVersion)" />
11+
<!--
12+
* Use 4.4.0-* instead of $(CoreFxVersion) to workaround "SqlClient fails with netcoreapp2.0 on Win7/Server2008"
13+
* https://github.com/dotnet/corefx/issues/18406
14+
* Revert when $(CoreFxVersion) is upgraded to 4.4.0-*
15+
-->
16+
<PackageReference Include="System.Data.SqlClient" Version="4.4.0-*" />
1217
<PackageReference Include="xunit" Version="$(XunitVersion)" />
1318
<PackageReference Include="xunit.runner.visualstudio" Version="$(XunitVersion)" />
1419
</ItemGroup>

0 commit comments

Comments
 (0)