Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlServerMigrationsSqlGenerator missing dependency object #10233

Closed
bricelam opened this issue Nov 7, 2017 · 3 comments
Closed

SqlServerMigrationsSqlGenerator missing dependency object #10233

bricelam opened this issue Nov 7, 2017 · 3 comments
Assignees
Labels
breaking-change closed-duplicate good first issue This issue should be relatively straightforward to fix. help wanted This issue involves technologies where we are not experts. Expert help would be appreciated. type-enhancement

Comments

@bricelam
Copy link
Contributor

bricelam commented Nov 7, 2017

public SqlServerMigrationsSqlGenerator(
    MigrationsSqlGeneratorDependencies dependencies,
    IMigrationsAnnotationProvider migrationsAnnotations)
    : base(dependencies)
{
    // ...
}
@ajcvickers
Copy link
Member

@bricelam Up to this point, provider implementations of services do not get dependency objects. This is because providers don't depend on the these base classes. However, I can see this would be useful for any public service implementations in the provider, but I don't think we have many of those.

@ajcvickers
Copy link
Member

Make sure to do this in a non-breaking way.

@ajcvickers ajcvickers modified the milestones: 2.1.0-preview1, 2.1.0 Jan 17, 2018
@ajcvickers ajcvickers modified the milestones: 2.1.0, Breaking Changes Jan 26, 2018
@ajcvickers ajcvickers modified the milestones: Breaking Changes, 3.0.0 May 18, 2018
@ajcvickers ajcvickers added help wanted This issue involves technologies where we are not experts. Expert help would be appreciated. and removed size~1-day labels Nov 7, 2018
@ajcvickers
Copy link
Member

Part of #12084

@ajcvickers ajcvickers removed this from the 3.0.0 milestone Jan 28, 2019
@bricelam bricelam added the good first issue This issue should be relatively straightforward to fix. label May 31, 2019
@ajcvickers ajcvickers reopened this Oct 16, 2022
@ajcvickers ajcvickers closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change closed-duplicate good first issue This issue should be relatively straightforward to fix. help wanted This issue involves technologies where we are not experts. Expert help would be appreciated. type-enhancement
Projects
None yet
Development

No branches or pull requests

2 participants