Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit which constructor to call by convention #10865

Closed
ajcvickers opened this issue Feb 3, 2018 · 1 comment
Closed

Revisit which constructor to call by convention #10865

ajcvickers opened this issue Feb 3, 2018 · 1 comment
Labels
breaking-change closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed. type-enhancement

Comments

@ajcvickers
Copy link
Contributor

Since part of the decision was driven by not making a breaking change. See issue #10852
@ajcvickers ajcvickers added this to the Breaking Changes milestone Feb 3, 2018
@ajcvickers ajcvickers self-assigned this May 18, 2018
@ajcvickers ajcvickers modified the milestones: Breaking Changes, 3.0.0 May 18, 2018
@ajcvickers ajcvickers mentioned this issue Sep 5, 2018
Closed
@ajcvickers ajcvickers mentioned this issue Nov 5, 2018
Closed
@ajcvickers
Copy link
Contributor Author

Marking for re-triage. The value of breaking here is probably not worth the cost. The current behavior is reasonable and possibly the best option. Still need to add API to configure this explicitly, but that's not a breaking change--see #10789.

@ajcvickers ajcvickers removed this from the 3.0.0 milestone Feb 18, 2019
@ajcvickers ajcvickers added the closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed. label Mar 10, 2022
@ajcvickers ajcvickers reopened this Oct 16, 2022
@ajcvickers ajcvickers closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2022
@ajcvickers ajcvickers removed their assignment Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed. type-enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bricelam @ajcvickers