Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider blocking inheritance scenarios until we have proper support #1423

Closed
divega opened this issue Jan 17, 2015 · 2 comments
Closed

Consider blocking inheritance scenarios until we have proper support #1423

divega opened this issue Jan 17, 2015 · 2 comments
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-unknown
Milestone
1.0.0

Comments

@divega
Copy link
Contributor

divega commented Jan 17, 2015

#247 covers adding support for some inheritance scenarios and per #743 we made sure we do not allow instances of unmapped derived types to be passed to APIs. However it seems that we should understand better what happens when the application tries to map two or more members of the same inheritance hierarchy in the same model and how whatever behavior we have now would break once we add proper inheritance support. If the break is rather obscure and/or can have severe consequences we should consider blocking the scenario.
@divega divega changed the title Consider block inheritance scenarios until we have proper support Consider blocking inheritance scenarios until we have proper support Jan 17, 2015
@rowanmiller rowanmiller added this to the 7.0.0 milestone Jan 19, 2015
@divega
Copy link
Contributor Author

divega commented Jan 19, 2015

@lukewaters Please start by investigating what the current behavior is. We can then decide what we want to do.

@lukewaters
Copy link
Contributor

Closing as work has begun on inheritance starting with aabb95f

@rowanmiller rowanmiller modified the milestones: 7.0.0, 7.0.0-beta6 Jul 15, 2015
@rowanmiller rowanmiller modified the milestones: 7.0.0-beta6, 7.0.0 Jul 15, 2015
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Oct 15, 2022
@ajcvickers ajcvickers modified the milestones: 1.0.0-beta6, 1.0.0 Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-unknown
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
4 participants
@divega @lukewaters @ajcvickers @rowanmiller