Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove or internalize JSON.NET dependency in Cosmos Provider #14570

Open
ajcvickers opened this issue Jan 31, 2019 · 5 comments
Open

Remove or internalize JSON.NET dependency in Cosmos Provider #14570

ajcvickers opened this issue Jan 31, 2019 · 5 comments
Assignees
@AndriySvyryd
Labels
area-cosmos breaking-change consider-for-current-release punted-for-6.0 punted-for-7.0 Originally planned for the EF Core 7.0 (EF7) release, but moved out due to resource constraints. type-enhancement
Milestone
Backlog

Comments

@ajcvickers
Copy link
Member

If this is not possible, then we should:

  • Give feedback to the SDK team
  • Raise this issue with respect to 3.0 shipping and come up with a plan
@AndriySvyryd
Copy link
Member

AndriySvyryd commented Jan 31, 2019 •
edited
Loading

We need to wait until JsonConverter(https://github.com/dotnet/corefx/issues/34372) is available to be able to implement CosmosJsonSerializer
Also see CosmosSystemTextJsonSerializer

@ajcvickers ajcvickers added this to the 3.0.0 milestone Feb 1, 2019
@ajcvickers
Copy link
Member Author

See also: Azure/azure-cosmos-dotnet-v3#37

@ajcvickers ajcvickers removed this from the 3.0.0 milestone Feb 1, 2019
@ajcvickers
Copy link
Member Author

Confirmed that we don't need to do this for 3.0.

@ajcvickers ajcvickers added this to the Backlog milestone Feb 8, 2019
@AndriySvyryd AndriySvyryd mentioned this issue Aug 20, 2019
Open
@AndriySvyryd AndriySvyryd mentioned this issue Jun 17, 2020
Merged
@AndriySvyryd
Copy link
Member

AndriySvyryd commented Jun 17, 2020 •
edited
Loading

Now this is blocked on writable DOM support: dotnet/runtime#29690

@AndriySvyryd AndriySvyryd self-assigned this Jun 17, 2020
@AndriySvyryd AndriySvyryd removed this from the Backlog milestone Jun 17, 2020
@AndriySvyryd AndriySvyryd mentioned this issue Jun 21, 2020
Closed
@ajcvickers ajcvickers added this to the 5.0.0 milestone Jun 22, 2020
@AndriySvyryd AndriySvyryd modified the milestones: 5.0.0, Backlog Jul 28, 2020
@AndriySvyryd
Copy link
Member

Note to implementor: Add byte[] converter for backwards compatibility dotnet/runtime#30456

@ajcvickers ajcvickers modified the milestones: Backlog, 6.0.0 Nov 2, 2020
@AndriySvyryd AndriySvyryd mentioned this issue Mar 11, 2021
Closed
@ajcvickers ajcvickers modified the milestones: 6.0.0, Backlog Jul 30, 2021
@ajcvickers ajcvickers modified the milestones: Backlog, 7.0.0 Oct 27, 2021
@ajcvickers ajcvickers added punted-for-7.0 Originally planned for the EF Core 7.0 (EF7) release, but moved out due to resource constraints. and removed propose-punt labels Jul 7, 2022
@ajcvickers ajcvickers modified the milestones: 7.0.0, Backlog Jul 7, 2022
@ajcvickers ajcvickers mentioned this issue Feb 8, 2024
Closed
@AndriySvyryd AndriySvyryd mentioned this issue Sep 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndriySvyryd AndriySvyryd

Labels
area-cosmos breaking-change consider-for-current-release punted-for-6.0 punted-for-7.0 Originally planned for the EF Core 7.0 (EF7) release, but moved out due to resource constraints. type-enhancement
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@ajcvickers @smitpatel @AndriySvyryd