Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve FK convention warning #15759

Closed
AndriySvyryd opened this issue May 20, 2019 · 3 comments · Fixed by #20616
Closed

Improve FK convention warning #15759

AndriySvyryd opened this issue May 20, 2019 · 3 comments · Fixed by #20616
Assignees
@lajones
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported good first issue This issue should be relatively straightforward to fix. punted-for-3.0 type-bug
Milestone
5.0.0

Comments

@AndriySvyryd
Copy link
Member

AndriySvyryd commented May 20, 2019 •
edited
Loading

Reported by @alexk8 in #10918 (comment):

I've found this issue, because I've run into a bit similar problem.
I've turned on verbose mode and I've got lots of messages:
[DBG] The foreign key properties haven't been configured by convention because the best match {'Id' : int} are incompatible with the current principal key {'Id' : string}. ...'.
The problem is that I do not understand what entities are involved there, I can only guess that they are probably from Identity template. That's not really a problem, but I think there more info may be added (entity-types).
@ajcvickers ajcvickers added this to the 3.0.0 milestone May 28, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0, Backlog Jun 28, 2019
@StrangeWill
Copy link

Would love to see this improved -- I have a wall of warnings that I have to find a way to figure out what is going on on a fairly decently sized database.

@aaronhudon
Copy link

Approaching a year on this one. Are there any suggestions on determining how to track down the source entities of this warning?

@AndriySvyryd AndriySvyryd modified the milestones: Backlog, 5.0.0 Mar 20, 2020
@AndriySvyryd AndriySvyryd added poachable good first issue This issue should be relatively straightforward to fix. labels Mar 20, 2020
@lajones lajones assigned lajones and unassigned AndriySvyryd Apr 13, 2020
@lajones lajones removed the poachable label Apr 13, 2020
@lajones
Copy link
Contributor

lajones commented Apr 13, 2020

Poaching.

@lajones lajones mentioned this issue Apr 13, 2020
Merged
@lajones lajones added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Apr 14, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-preview4 Apr 20, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0-preview4, 5.0.0 Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lajones lajones

Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported good first issue This issue should be relatively straightforward to fix. punted-for-3.0 type-bug
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Fix for 15759. Update an error message for FK properties mismatch dotnet/efcore
5 participants
@StrangeWill @ajcvickers @lajones @aaronhudon @AndriySvyryd