Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EF Core PS Module Manifest is duplicated internally 29 times #16616

Closed
Psypher9 opened this issue Jul 16, 2019 · 5 comments · Fixed by #16854
Closed

EF Core PS Module Manifest is duplicated internally 29 times #16616

Psypher9 opened this issue Jul 16, 2019 · 5 comments · Fixed by #16854
Assignees
@bricelam
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported type-cleanup
Milestone
3.0.0

Comments

@Psypher9
Copy link
Contributor

Describe what is not working as expected.

I have been getting errors on the PMC when starting up my project for testing the work I'm doing for #577 and the first error is coming from EFCore.Tools\tools\init.ps1. The error says that EntityFrameworkCore.psd1 did not result in a valid module manifest.
image

I went and looked at the .psd1 file in that location to see why it wasn't valid and the Manifest object was duplicated 29 times inside of the file.

image

The projects I've mainly been working in have been EFCore.Design and EFCore.Tools inside the .psm1 file, but I've not been doing anything with the build process. Could there be something I've done to affect the output module manifest?

Steps to reproduce

The steps I took were:

  • run build -pack in the EFCore folder
  • Set C:\<path_to_EFCore_dir>\artifacts\packages\Debug\Shipping to my only package feed in VS
  • close and re-open my test solution
  • re-install the local packages I needed
  • Restart VS again
  • Open the PMC

Further technical details

EF Core version: 3.0.0-dev
Database Provider: Microsoft.EntityFrameworkCore.SqlServer
Operating system: Windows 10
IDE: Visual Studio 2019 16.1.3
@ajcvickers
Copy link
Contributor

@Psypher9 Sorry for being slow responding to this. I've never seen this while working on EF. @bricelam might have some pointers, but it sounds like however you are changing the module it is not happening in a clean way.

@ajcvickers ajcvickers added help wanted This issue involves technologies where we are not experts. Expert help would be appreciated. type-investigation labels Jul 25, 2019
@Psypher9
Copy link
Contributor Author

Okay, cool. I'm not sure what I would be doing to cause that, but I will take another look. Any pointers on where to start would be very welcome! Thank you for looking in to it.

@ajcvickers
Copy link
Contributor

@Psypher9 The workaround for now is to clean (e.g. git clean -xdf) and then re-build. We will look into fixing the underlying issue probably after 3.0 ships.

@ajcvickers ajcvickers added this to the Backlog milestone Jul 29, 2019
@bricelam
Copy link
Contributor

I ran into this too when trying to port the replacement code to EF6. It might be as simple as adding Overwrite="True" to this line.

I might make additional changes to the way we do this in EF6. I'll be sure to port my changes (and fixes) back to EF Core

@Psypher9
Copy link
Contributor Author

Okay cool. I will give that a shot and let you know!

Thanks @bricelam!

@bricelam bricelam added closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. and removed help wanted This issue involves technologies where we are not experts. Expert help would be appreciated. labels Jul 30, 2019
@bricelam bricelam modified the milestones: Backlog, 3.0.0 Jul 30, 2019
@bricelam bricelam mentioned this issue Jul 30, 2019
Merged
@ajcvickers ajcvickers modified the milestones: 3.0.0, 3.0.0-preview9 Aug 21, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0-preview9, 3.0.0 Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bricelam bricelam

Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported type-cleanup
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Build: Tweak GeneratedContent code
3 participants
@bricelam @ajcvickers @Psypher9