The type cannot be marked as owned because a non-owned entity type with the same name already exists #18092

codehunter13 · 2019-09-27T09:52:03Z

Upgraded to ef core 3.0 and OwnsMany calls are giving the following error:

The entity:

The valueobject:

This was working in the previous ef core version

smitpatel · 2019-09-27T20:55:49Z

Intentional breaking change as per #9148

@AndriySvyryd - Do you want to add this to breaking changes doc?

smitpatel · 2019-09-27T21:02:47Z

@codehunter13 - I could not see where you are configuring UserNotification as regular entity in your code snippets but running the code snippets you posted also does not throw exception for me.
Can you verify that you are hitting what is in #9148? If not can you provide a full repro code which shows the issue?

ghost · 2019-09-30T10:47:20Z

I have the same error after upgrade
InvalidOperationException: The type 'OwnedCustomerName' cannot be marked as owned because a non-owned entity type with the same name already exists.

ghost · 2019-09-30T10:48:50Z

That's my code

 public class CustomerContact
    {
        public CustomerContact()
        {
        }

        public string EmailAddress { get; set; }

        public string Phone { get; set; }
    }

    public class CustomerName
    {
        public CustomerName()
        {
            this.Contact = new CustomerContact();
        }

        public string FirstName { get; set; }


        public string MiddleName { get; set; }

   
        public string LastName { get; set; }

        public CustomerContact Contact { get; set; }
    }

  modelBuilder.Entity<CustomerName>(entity =>
            {
                entity.OwnsOne(x => x.Contact).Property(c => c.EmailAddress).HasColumnName("EmailAddress").HasMaxLength(50);

                entity.OwnsOne(x => x.Contact).Property(c => c.Phone).HasColumnName("Phone").HasColumnType("Phone")
                    .HasMaxLength(25);
            });


    modelBuilder.Entity<Customer>(entity =>
            {
                entity.ToTable("Customer", "SalesLT");

                entity.Ignore(e => e.AddressCount);

                entity.HasIndex(e => e.Rowguid)
                    .HasName("AK_Customer_rowguid")
                    .IsUnique();

                entity.Property(e => e.CustomerId).HasColumnName("CustomerID");

                entity.Property(e => e.CompanyName).HasMaxLength(128);

                #region Owned Types
               
                entity.OwnsOne(x => x.CustomerName).Property(c => c.FirstName).HasColumnName("FirstName").IsRequired()
                    .HasColumnType("Name")
                    .HasMaxLength(50);

                entity.OwnsOne(x => x.CustomerName).Property(c => c.MiddleName).HasColumnName("MiddleName")
                    .HasColumnType("Name")
                    .HasMaxLength(50);

                entity.OwnsOne(x => x.CustomerName).Property(c => c.LastName).HasColumnName("LastName").IsRequired()
                    .HasColumnType("Name")
                    .HasMaxLength(50);

                #endregion

                entity.Property(e => e.ModifiedDate)
                    .HasColumnType("datetime")
                    .HasDefaultValueSql("(getdate())");

                entity.Property(e => e.NameStyle).HasColumnType("NameStyle");

                entity.Property(e => e.PasswordHash)
                    .IsRequired()
                    .HasMaxLength(128)
                    .IsUnicode(false);

                entity.Property(e => e.PasswordSalt)
                    .IsRequired()
                    .HasMaxLength(10)
                    .IsUnicode(false);

                entity.Property(e => e.Rowguid)
                    .HasColumnName("rowguid")
                    .HasDefaultValueSql("(newid())");

                entity.Property(e => e.SalesPerson).HasMaxLength(256);

                entity.Property(e => e.Suffix).HasMaxLength(10);

                entity.Property(e => e.Title).HasMaxLength(8);
            });

codehunter13 · 2019-09-30T14:10:46Z

I got the error in two situations:

In my base db context i was adding shadowed properties as followed:

And this code was running before my ownsmany calls. so my fault (but it was working previously)
Using IEntityMap classes to configure owned types doesnt work anymore and gives the same error. Solved by configuring those types in the owner

AndriySvyryd · 2019-09-30T16:00:08Z

@codehunter13 The exception was introduced to catch configuration like that. It might have worked for your model, but in general it's not supported and could've let to unexpected behavior.

ghost · 2019-09-30T16:34:17Z

Looks like i solved this too by changing configuration. Thanks.

      modelBuilder.Entity<Customer>(entity =>
            {
                entity.ToTable("Customer", "SalesLT");

                entity.Ignore(e => e.AddressCount);

                entity.HasIndex(e => e.Rowguid)
                    .HasName("AK_Customer_rowguid")
                    .IsUnique();

                entity.Property(e => e.CustomerId).HasColumnName("CustomerID");

                entity.Property(e => e.CompanyName).HasMaxLength(128);

                #region Owned Types

                var ownedCustName = entity.OwnsOne(x => x.CustomerName);

                ownedCustName.Property(c => c.FirstName).HasColumnName("FirstName").IsRequired()
                    .HasColumnType("Name")
                    .HasMaxLength(50);

                ownedCustName.Property(c => c.MiddleName).HasColumnName("MiddleName")
                    .HasColumnType("Name")
                    .HasMaxLength(50);

                ownedCustName.Property(c => c.LastName).HasColumnName("LastName").IsRequired()
                    .HasColumnType("Name")
                    .HasMaxLength(50);

                var ownedContact = ownedCustName.OwnsOne(x => x.Contact);

                ownedContact.Property(c => c.EmailAddress).HasColumnName("EmailAddress").HasMaxLength(50);

                ownedContact.Property(c => c.Phone).HasColumnName("Phone").HasColumnType("Phone")
                    .HasMaxLength(25);
                #endregion

                entity.Property(e => e.ModifiedDate)
                    .HasColumnType("datetime")
                    .HasDefaultValueSql("(getdate())");

                entity.Property(e => e.NameStyle).HasColumnType("NameStyle");

                entity.Property(e => e.PasswordHash)
                    .IsRequired()
                    .HasMaxLength(128)
                    .IsUnicode(false);

                entity.Property(e => e.PasswordSalt)
                    .IsRequired()
                    .HasMaxLength(10)
                    .IsUnicode(false);

                entity.Property(e => e.Rowguid)
                    .HasColumnName("rowguid")
                    .HasDefaultValueSql("(newid())");

                entity.Property(e => e.SalesPerson).HasMaxLength(256);

                entity.Property(e => e.Suffix).HasMaxLength(10);

                entity.Property(e => e.Title).HasMaxLength(8);
            });

voroninp · 2019-10-23T12:08:44Z

@AndriySvyryd Yep, this is a breaking change. And I can change code, but it's not cool that I have to change ContextModelSnapshot, i.e. I have no chance for rollback now as I understood.

System.InvalidOperationException: The type 'Connect.Device.BusinessModel.Values.OrganizationAddress' cannot be configured as non-owned because an owned entity type with the same name already exists.
   at Microsoft.EntityFrameworkCore.Metadata.Internal.InternalModelBuilder.Entity(TypeIdentity& type, ConfigurationSource configurationSource, Nullable`1 shouldBeOwned)
   at Microsoft.EntityFrameworkCore.Metadata.Internal.InternalModelBuilder.Entity(String name, ConfigurationSource configurationSource, Nullable`1 shouldBeOwned)
   at Microsoft.EntityFrameworkCore.Metadata.Builders.OwnedNavigationBuilder.FindRelatedEntityType(String relatedTypeName, String navigationName)
   at Microsoft.EntityFrameworkCore.Metadata.Builders.OwnedNavigationBuilder.HasOne(String relatedTypeName, String navigationName)
   at Microsoft.EntityFrameworkCore.Metadata.Builders.OwnedNavigationBuilder.HasOne(String navigationName)
   at Connect.Device.DAL.Migrations.Migrations.DeviceContextModelSnapshot.<>c.<BuildModel>b__0_42(OwnedNavigationBuilder b2) in C:\Users\pavelvoronin\Source\Repos\connect.device\Connect.Device.DAL.Migrations\Migrations\DeviceContextModelSnapshot.cs:line 3093
   at Microsoft.EntityFrameworkCore.Metadata.Builders.OwnedNavigationBuilder.OwnsOne(String ownedTypeName, String navigationName, Action`1 buildAction)
   at Connect.Device.DAL.Migrations.Migrations.DeviceContextModelSnapshot.<>c.<BuildModel>b__0_39(OwnedNavigationBuilder b1) in C:\Users\pavelvoronin\Source\Repos\connect.device\Connect.Device.DAL.Migrations\Migrations\DeviceContextModelSnapshot.cs:line 3077
   at Microsoft.EntityFrameworkCore.Metadata.Builders.EntityTypeBuilder.OwnsOne(String ownedTypeName, String navigationName, Action`1 buildAction)
   at Connect.Device.DAL.Migrations.Migrations.DeviceContextModelSnapshot.<>c.<BuildModel>b__0_29(EntityTypeBuilder b) in C:\Users\pavelvoronin\Source\Repos\connect.device\Connect.Device.DAL.Migrations\Migrations\DeviceContextModelSnapshot.cs:line 3046
   at Microsoft.EntityFrameworkCore.ModelBuilder.Entity(String name, Action`1 buildAction)
   at Connect.Device.DAL.Migrations.Migrations.DeviceContextModelSnapshot.BuildModel(ModelBuilder modelBuilder) in C:\Users\pavelvoronin\Source\Repos\connect.device\Connect.Device.DAL.Migrations\Migrations\DeviceContextModelSnapshot.cs:line 3044
   at Microsoft.EntityFrameworkCore.Infrastructure.ModelSnapshot.CreateModel()
   at Microsoft.EntityFrameworkCore.Infrastructure.ModelSnapshot.get_Model()
   at Microsoft.EntityFrameworkCore.Migrations.Design.MigrationsScaffolder.ScaffoldMigration(String migrationName, String rootNamespace, String subNamespace, String language)
   at Microsoft.EntityFrameworkCore.Design.Internal.MigrationsOperations.AddMigration(String name, String outputDir, String contextType)
   at Microsoft.EntityFrameworkCore.Design.OperationExecutor.AddMigrationImpl(String name, String outputDir, String contextType)
   at Microsoft.EntityFrameworkCore.Design.OperationExecutor.AddMigration.<>c__DisplayClass0_0.<.ctor>b__0()
   at Microsoft.EntityFrameworkCore.Design.OperationExecutor.OperationBase.<>c__DisplayClass3_0`1.<Execute>b__0()
   at Microsoft.EntityFrameworkCore.Design.OperationExecutor.OperationBase.Execute(Action action)

The type 'Connect.Device.BusinessModel.Values.OrganizationAddress' cannot be configured as non-owned because an owned entity type with the same name already exists.

modelBuilder.Entity("Connect.Device.BusinessModel.Entities.Organization", b =>
    {
        b.OwnsOne("Connect.Device.BusinessModel.Values.OrganizationAddress", "Address", b1 =>
            {
                b1.Property<Guid>("OrganizationId");

                b1.Property<string>("City")
                    .HasMaxLength(255);

                b1.Property<int>("CountryId");

                b1.Property<string>("PostalCode")
                    .HasMaxLength(50);

                b1.Property<string>("Street")
                    .HasMaxLength(255);

                b1.HasKey("OrganizationId");

                b1.HasIndex("CountryId");

                b1.ToTable("OrganizationAddress");

                b1.HasOne("Connect.Device.BusinessModel.Entities.Country")
                    .WithMany()
                    .HasForeignKey("CountryId")
                    .OnDelete(DeleteBehavior.Restrict);

                b1.HasOne("Connect.Device.BusinessModel.Entities.Organization")
                    .WithOne("Address")
                    .HasForeignKey("Connect.Device.BusinessModel.Values.OrganizationAddress", "OrganizationId")
                    .OnDelete(DeleteBehavior.Cascade);

                b1.OwnsOne("Connect.Device.BusinessModel.Values.House", "House", b2 =>
                    {
                        b2.Property<Guid>("OrganizationAddressOrganizationId");

                        b2.Property<string>("Number")
                            .HasColumnName("HouseNumber")
                            .HasMaxLength(50);

                        b2.Property<string>("Suffix")
                            .HasColumnName("HouseNumberSuffix")
                            .HasMaxLength(50);

                        b2.HasKey("OrganizationAddressOrganizationId");

                        b2.ToTable("OrganizationAddress");

                        // line 3093
                        b2.HasOne("Connect.Device.BusinessModel.Values.OrganizationAddress")
                            .WithOne("House")
                            .HasForeignKey("Connect.Device.BusinessModel.Values.House", "OrganizationAddressOrganizationId")
                            .OnDelete(DeleteBehavior.Cascade);
                    });
            });

And org configuration now looks like this:

public void Configure(EntityTypeBuilder<Organization> builder)
{
    builder.ToTable("Organization");

    builder.Property(_ => _.Version)
        .IsConcurrencyToken()
        .HasDefaultValue(0);

    builder.OwnsOne(m => m.Address, b =>
    {
        b.WithOwner().HasForeignKey("OrganizationId");

        b.ToTable("OrganizationAddress");

        b.HasOne<Country>()
            .WithMany()
            .HasForeignKey(m => m.CountryId)
            .IsRequired()
            .OnDelete(DeleteBehavior.Restrict);

        b.OwnsOne(
            m => m.House,
            bld =>
            {
                bld.Property(m => m.Number).HasColumnName("HouseNumber");
                bld.Property(m => m.Suffix).HasColumnName("HouseNumberSuffix");
            });
    });

    builder.OwnsOne(
        m => m.ExternalIds,
        act => { act.ToTable("OrganizationExternalIds"); });

    builder.OwnsOne(
        m => m.ExternalReferences,
        act => { act.ToTable("OrganizationExternalReferences"); });

    builder.Property(m => m.SendInvoiceTo).HasDefaultValue(FulfilmentPartnerSendsInvoiceTo.OurCompany);
}

AndriySvyryd · 2019-10-23T16:02:21Z

@voroninp The snapshot issue is a bug: #18183

codehunter13 added the type-bug label Sep 27, 2019

smitpatel closed this as completed Sep 27, 2019

smitpatel added closed-by-design and removed type-bug labels Sep 27, 2019

smitpatel reopened this Sep 27, 2019

smitpatel added type-bug and removed closed-by-design labels Sep 27, 2019

AndriySvyryd added the closed-no-further-action The issue is closed and no further action is planned. label Sep 30, 2019

AndriySvyryd closed this as completed Sep 30, 2019

ajcvickers added customer-reported and removed type-bug labels Oct 6, 2019

michielpeeters mentioned this issue Feb 4, 2020

Migration ef core 2.2 to 3.1 with owned entities #19789

Closed

ajcvickers reopened this Oct 16, 2022

ajcvickers closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

The type cannot be marked as owned because a non-owned entity type with the same name already exists #18092

The type cannot be marked as owned because a non-owned entity type with the same name already exists #18092

codehunter13 commented Sep 27, 2019 •

edited

Loading

smitpatel commented Sep 27, 2019

smitpatel commented Sep 27, 2019

ghost commented Sep 30, 2019

ghost commented Sep 30, 2019 •

edited by ghost

Loading

codehunter13 commented Sep 30, 2019

AndriySvyryd commented Sep 30, 2019

ghost commented Sep 30, 2019 •

edited by ghost

Loading

voroninp commented Oct 23, 2019 •

edited

Loading

AndriySvyryd commented Oct 23, 2019

The type cannot be marked as owned because a non-owned entity type with the same name already exists #18092

The type cannot be marked as owned because a non-owned entity type with the same name already exists #18092

Comments

codehunter13 commented Sep 27, 2019 • edited Loading

smitpatel commented Sep 27, 2019

smitpatel commented Sep 27, 2019

ghost commented Sep 30, 2019

ghost commented Sep 30, 2019 • edited by ghost Loading

codehunter13 commented Sep 30, 2019

AndriySvyryd commented Sep 30, 2019

ghost commented Sep 30, 2019 • edited by ghost Loading

voroninp commented Oct 23, 2019 • edited Loading

AndriySvyryd commented Oct 23, 2019

codehunter13 commented Sep 27, 2019 •

edited

Loading

ghost commented Sep 30, 2019 •

edited by ghost

Loading

ghost commented Sep 30, 2019 •

edited by ghost

Loading

voroninp commented Oct 23, 2019 •

edited

Loading