Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question] Expression Rewriting #18244

Closed
sitepodmatt opened this issue Oct 6, 2019 · 2 comments
Closed

[question] Expression Rewriting #18244

sitepodmatt opened this issue Oct 6, 2019 · 2 comments

Comments

@sitepodmatt
Copy link

sitepodmatt commented Oct 6, 2019

We currently have an expression rewriter (using ExpressionVisitor) that takes the predicate or selector and converts it to something EF can understand using our EAV model...

e.g. queryable.Where(EFHelpers.Rewrite(e => e.name = "matt")));

We have this working nicely now, its ugly to have to wrap every expression. Is there a way to intercept expressions without this explicit wrapping each time or something like dbContext.ExpressionVisitor = ourVisitor ?

@ajcvickers ajcvickers added this to the Backlog milestone Oct 9, 2019
@ajcvickers
Copy link
Contributor

Putting this on the backlog to consider adding hooks for this. However, there are different places in the pipeline where visitors can run, and different constraints/requirements for each place, so it is not trivial to create a pit-of-success for such extensibility.

@ajcvickers
Copy link
Contributor

Covered by #19748

@ajcvickers ajcvickers removed this from the Backlog milestone Nov 10, 2021
@ajcvickers ajcvickers removed their assignment Nov 10, 2021
@ajcvickers ajcvickers reopened this Oct 16, 2022
@ajcvickers ajcvickers closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants