Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sqlite: CommandText should be an empty string by default #743 #19162

Closed
roji opened this issue Dec 4, 2019 · 0 comments · Fixed by #20151
Closed

Sqlite: CommandText should be an empty string by default #743 #19162

roji opened this issue Dec 4, 2019 · 0 comments · Fixed by #20151
Assignees
@bricelam
Labels
area-adonet-sqlite closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
5.0.0

Comments

@roji
Copy link
Member

roji commented Dec 4, 2019

As per the docs.

I'd also consider throwing if null is set, although that would be a slightly bigger breaking change.
@ajcvickers ajcvickers added this to the 5.0.0 milestone Dec 6, 2019
@roji roji mentioned this issue Dec 9, 2019
Merged
@bricelam bricelam mentioned this issue Mar 3, 2020
Merged
@bricelam bricelam added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Mar 3, 2020
@roji roji mentioned this issue Mar 4, 2020
Closed
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-preview2 Mar 13, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0-preview2, 5.0.0 Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bricelam bricelam

Labels
area-adonet-sqlite closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Microsoft.Data.Sqlite: Default CommandText to an empty string
3 participants
@bricelam @ajcvickers @roji