-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mapping attribute for IsUnicode #19794
Labels
area-model-building
closed-fixed
The issue has been fixed and is/will be included in the release indicated by the issue milestone.
community-contribution
customer-reported
type-enhancement
Milestone
Comments
Duplicate of #10864 |
ajcvickers
changed the title
Add attributes for parity with PropertyBuilder fluent methods
Mapping attribute for IsUnicode
Jun 22, 2020
ajcvickers
added
good first issue
This issue should be relatively straightforward to fix.
type-enhancement
area-model-building
and removed
closed-duplicate
labels
Jun 22, 2020
This was referenced Sep 11, 2020
Design questions for @dotnet/efteam
|
|
smitpatel
added
closed-fixed
The issue has been fixed and is/will be included in the release indicated by the issue milestone.
community-contribution
labels
Oct 27, 2020
Fixed in #22514 |
Thanks guys! |
ajcvickers
removed
the
good first issue
This issue should be relatively straightforward to fix.
label
Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-model-building
closed-fixed
The issue has been fixed and is/will be included in the release indicated by the issue milestone.
community-contribution
customer-reported
type-enhancement
What problem are you trying to solve?
We prefer to configure our entities via properties on the entities themselves, as opposed to using the fluent syntax, because we've found it makes the code more readable. However, because not every method on
PropertyBuilder
has an associated attribute (e.g.IsUnicode
), it's not possible to use this approach - so we either have to use a half-half approach, or go full fluent; neither of which are desirable.Describe the solution you'd like
Add attributes that mirror all available methods exposed by
PropertyBuilder
and result in the same behaviour.This would have the additional benefit that EF would no longer have to rely on (mis)-using the attributes in the
System.Data.DataAnnotations
namespace, which are rather... overloaded at this point. That would make it easier for people to transition between fluent syntax and attributes, without needing an entire article to inform users how to map between both ways.The text was updated successfully, but these errors were encountered: