Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compilation perf: consider caching hash codes for immutable query expression node types #19860

Closed
roji opened this issue Feb 10, 2020 · 1 comment
Closed

Compilation perf: consider caching hash codes for immutable query expression node types #19860

roji opened this issue Feb 10, 2020 · 1 comment
Assignees
@roji
Labels
area-perf closed-duplicate type-enhancement

Comments

@roji
Copy link
Member

roji commented Feb 10, 2020 •
edited
Loading

We currently recalculate hash codes for nodes, but we could cache them (almost all are immutable).

See #19859 which is about not exhaustively including all query sub-nodes in hash calculation.
See #19737 for a case where exhaustive hash code calculation caused exponential calculation.
This was referenced Feb 10, 2020
Closed
Closed
@ajcvickers ajcvickers added this to the Backlog milestone Feb 10, 2020
@roji roji mentioned this issue Jan 14, 2024
Merged
@roji
Copy link
Member Author

roji commented Aug 22, 2024

Duplicate of #34149

@roji roji marked this as a duplicate of #34149 Aug 22, 2024
@roji roji closed this as not planned Won't fix, can't repro, duplicate, stale Aug 22, 2024
@roji roji removed this from the Backlog milestone Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roji roji

Labels
area-perf closed-duplicate type-enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ajcvickers @roji