Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small mistake in SqlUnaryExpression::Print #23985

Closed
dmitry-lipetsk opened this issue Jan 26, 2021 · 0 comments · Fixed by #24016
Closed

Small mistake in SqlUnaryExpression::Print #23985

dmitry-lipetsk opened this issue Jan 26, 2021 · 0 comments · Fixed by #24016
Assignees
@maumar
Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. community-contribution customer-reported good first issue This issue should be relatively straightforward to fix. type-bug
Milestone
6.0.0

Comments

@dmitry-lipetsk
Copy link
Contributor

dmitry-lipetsk commented Jan 26, 2021 •
edited
Loading

efcore/src/EFCore.Relational/Query/SqlExpressions/SqlUnaryExpression.cs

Lines 109 to 114 in 7c8ff90

expressionPrinter.Append("CAST(");
expressionPrinter.Visit(Operand);
expressionPrinter.Append(")");
expressionPrinter.Append(" AS ");
expressionPrinter.Append(TypeMapping.StoreType);
expressionPrinter.Append(")");

I think, must be:

expressionPrinter.Append("CAST("); 
expressionPrinter.Visit(Operand);
expressionPrinter.Append(" AS "); 
expressionPrinter.Append(TypeMapping.StoreType); 
expressionPrinter.Append(")");
@smitpatel smitpatel added good first issue This issue should be relatively straightforward to fix. type-enhancement labels Jan 26, 2021
@Marusyk Marusyk mentioned this issue Jan 28, 2021
Merged
@ajcvickers ajcvickers added this to the 6.0.0 milestone Jan 29, 2021
@ajcvickers ajcvickers modified the milestones: 6.0.0, 6.0.0-preview2 Mar 5, 2021
@ajcvickers ajcvickers added customer-reported closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. labels Apr 28, 2021
@ajcvickers ajcvickers modified the milestones: 6.0.0-preview2, 6.0.0 Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maumar maumar

Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. community-contribution customer-reported good first issue This issue should be relatively straightforward to fix. type-bug
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Fix mistake in SqlUnaryExpression::Print Marusyk/efcore
4 participants
@ajcvickers @smitpatel @maumar @dmitry-lipetsk