Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate the new queryable Take(Range) and ElementAt(Index) #24479

Open
Tracked by #25570
roji opened this issue Mar 23, 2021 · 5 comments
Open
Tracked by #25570

Translate the new queryable Take(Range) and ElementAt(Index) #24479

roji opened this issue Mar 23, 2021 · 5 comments
Assignees
Labels
area-query consider-for-current-release punted-for-7.0 Originally planned for the EF Core 7.0 (EF7) release, but moved out due to resource constraints. type-enhancement
Milestone

Comments

@roji
Copy link
Member

roji commented Mar 23, 2021

dotnet/runtime#28776 introduced a new Queryable Take operator that accepts a Range and a new ElementAt that accepts an Index. In a nutshell, source.Take(2..7) is a shorter version of source.Take(7).Skip(2) (see the issue for more variants and discussion).

Note discussion on Index/Range in expression trees in dotnet/runtime#28776 (comment) (/cc @AndriySvyryd).

@roji roji changed the title Translate the new queryable Take(Range) Translate the new queryable Take(Range) and ElementAt(Index) Mar 23, 2021
@ajcvickers ajcvickers added this to the Backlog milestone Mar 23, 2021
@julealgon
Copy link

Will this translation be done in a place where all specific providers will automatically benefit from it, or will specific providers need to provide their own translation for it?

@roji
Copy link
Member Author

roji commented Aug 2, 2021

It's likely that relational providers would get this without any extra work, but whether non-relational providers would is an open question.

@ajcvickers
Copy link
Contributor

Note from triage: putting this in 7.0 to investigate reasonable translations.

@ajcvickers ajcvickers added propose-punt punted-for-7.0 Originally planned for the EF Core 7.0 (EF7) release, but moved out due to resource constraints. and removed propose-punt labels Jul 6, 2022
@ajcvickers ajcvickers modified the milestones: 7.0.0, Backlog Jul 7, 2022
@ajcvickers ajcvickers assigned maumar and unassigned roji Oct 20, 2022
@maumar maumar assigned maumar and unassigned maumar Nov 5, 2022
@SvenKrauter

This comment was marked as resolved.

@ajcvickers

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-query consider-for-current-release punted-for-7.0 Originally planned for the EF Core 7.0 (EF7) release, but moved out due to resource constraints. type-enhancement
Projects
None yet
Development

No branches or pull requests

5 participants