Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all orderings for last collection join with composite keys #25481

Open
roji opened this issue Aug 10, 2021 · 2 comments
Open

Remove all orderings for last collection join with composite keys #25481

roji opened this issue Aug 10, 2021 · 2 comments

Comments

@roji
Copy link
Member

roji commented Aug 10, 2021

In #19828, we removed the last ordering for collection joins. We could go further and remove the set of orderings which correspond to the keys of the last collection join, if that join includes composite keys; that would allow us to remove multiple unnecessary orderings, not just one.

See discussion in #24360 (comment) and a draft attempt by @Emill in #24401.

@stevendarby
Copy link
Contributor

@roji do you have any sense of whether removing only the last column in a composite key scenario (i.e. only removing part of the last composite key) will give a perf boost, or is that likely to only come when this issue is fixed and the full key is removed? Just curious!

@roji
Copy link
Member Author

roji commented Aug 11, 2021

@stevendarby removing the last column (#19828) should still give a perf boost in the composite key scenario - removing an ordering should generally means less work for the database, regardless of whether that ordering is on a part of a composite key or not.

@ajcvickers ajcvickers added this to the Backlog milestone Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants