Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid generating proxies when they're not needed #25892

Closed
roji opened this issue Sep 6, 2021 · 2 comments
Closed

Avoid generating proxies when they're not needed #25892

roji opened this issue Sep 6, 2021 · 2 comments

Comments

@roji
Copy link
Member

roji commented Sep 6, 2021

Proxy generation is a very heavy process perf-wise, and we may be doing it in cases where we don't have to (came out of investigating the model in #20135).

  • For lazy loading proxies, a type without any virtual methods shouldn't require proxies
  • For change tracking proxies, we currently set up all the entity types in the model (and throw if any type is sealed). We could have some sort of type-by-type opt-in/opt-out.

/cc @ajcvickers

@ajcvickers
Copy link
Member

Partially covered by #10787

Note that mixing notification entities with non-notification entities tends to be a pit of failure (based on EF6 experience) which is why we do not allow it in EF Core.

@ajcvickers
Copy link
Member

Note from triage:

@ajcvickers ajcvickers reopened this Oct 16, 2022
@ajcvickers ajcvickers closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants