Altering a nullable column to be not nullable with a default value fails during migration

[ChristopherHaws]

The following migration results in the following SQL migration script which fails. The ADD DEFAULT query should run before the ALTER COLUMN script.

migrationBuilder.AlterColumn<string>(
    name: "Column",
    schema: "Schema",
    table: "Table",
    type: "nvarchar(max)",
    nullable: false,
    defaultValueSql: "'[]'",
    oldClrType: typeof(string),
    oldType: "nvarchar(max)",
    oldNullable: true);

ALTER TABLE [Schema].[Table] ALTER COLUMN [Column] nvarchar(max) NOT NULL;
ALTER TABLE [Schema].[Table] ADD DEFAULT ('[]') FOR [Column];

SQL Exception

Cannot insert the value NULL into column 'Column', table 'db.Schema.Table'; column does not allow nulls. UPDATE fails. 

Include provider and version information

EF Core version: 6.0.0
Database provider: Microsoft.EntityFrameworkCore.SqlServer
Target framework: .NET 6
Operating system: Windows 11
IDE: Visual Studio 2022

[ajcvickers]

Duplicate of #21765? /cc @bricelam

[HerrNiklasRaab]

Same here, but in my case, the column I want to make non-nullable has no null values, but it still fails to migrate. Which seems different then this issue, what is described here: #21765 (comment)

[roji]

The ADD DEFAULT query should run before the ALTER COLUMN script.

The ordering actually doesn't matter - if we add the default before making the column non-nullable, you still get the error (see https://github.com/npgsql/npgsql/issues/4186#issuecomment-982512914). And yeah, seems like this is a dup of #21765.