Scaffolding tool is generating invalid C# code when generating many-to-many relationships

[mjhoffm2]

In entity framework 6, the new scaffolding tool is generating many-to-many relationships differently than it did in previous versions. I would like the ability to opt out of this, as mentioned in #26820 but that is a different discussion.

I put together a very basic example that just has an Author table, a Book table, and an AuthorBook table.

When generating the InverseProperty attribute for the two tables, it generates invalid code. For example, on the "Author" collection property on the "Book" class. It generates [InverseProperty(nameof(Author.Book))]. However, this results in the error "CS0120 An object reference is required for the non-static field, method, or property 'Book.Author'"
The issue appears to be due to the fact that the generated property on this class is also called "Author", which takes precedence over the class called "Author" when resolving the identifier.

Here is the code I used:

CREATE TABLE [dbo].[Author](
	[Id] [int] IDENTITY(1,1) NOT NULL,
	[Name] [nvarchar](max) NULL,
 CONSTRAINT [PK_Author] PRIMARY KEY CLUSTERED 
 (
	[Id] ASC
 )
)
GO

CREATE TABLE [dbo].[AuthorBook](
	[AuthorId] [int] NOT NULL,
	[BookId] [int] NOT NULL,
 CONSTRAINT [PK_AuthorBook] PRIMARY KEY CLUSTERED 
 (
	[AuthorId] ASC,
	[BookId] ASC
 )
)


CREATE TABLE [dbo].[Book](
	[Id] [int] IDENTITY(1,1) NOT NULL,
	[Title] [nvarchar](max) NULL,
 CONSTRAINT [PK_Book] PRIMARY KEY CLUSTERED 
 (
	[Id] ASC

 )
)
GO
ALTER TABLE [dbo].[AuthorBook]  WITH CHECK ADD  CONSTRAINT [FK_AuthorBook_Author] FOREIGN KEY([AuthorId])
REFERENCES [dbo].[Author] ([Id])
GO
ALTER TABLE [dbo].[AuthorBook] CHECK CONSTRAINT [FK_AuthorBook_Author]
GO
ALTER TABLE [dbo].[AuthorBook]  WITH CHECK ADD  CONSTRAINT [FK_AuthorBook_Book] FOREIGN KEY([BookId])
REFERENCES [dbo].[Book] ([Id])
GO
ALTER TABLE [dbo].[AuthorBook] CHECK CONSTRAINT [FK_AuthorBook_Book]
GO

Here is the Scaffolding command I used:

Scaffold-DbContext "Server=.\SQLEXPRESS;Database=test-database;Trusted_Connection=True;TrustServerCertificate=True;" Microsoft.EntityFrameworkCore.SqlServer -o Models/Database -Context MyDbContext -f -d -v -NoPluralize

Include provider and version information

EF Core version: 6.0.1
Database provider: Microsoft.EntityFrameworkCore.SqlServer
Target framework: .NET 6.0
Operating system: Windows 10
IDE: Visual Studio 2022

[mjhoffm2]

Oops looks like this is a duplicate of #26588