Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ModificationCommandComparer compare provider values #27761

Open
Tracked by #22959
AndriySvyryd opened this issue Apr 5, 2022 · 0 comments
Open
Tracked by #22959

Make ModificationCommandComparer compare provider values #27761

AndriySvyryd opened this issue Apr 5, 2022 · 0 comments
Labels
area-save-changes type-enhancement
Milestone
Backlog

Comments

@AndriySvyryd
Copy link
Member

AndriySvyryd commented Apr 5, 2022 •
edited
Loading

With table sharing where the PKs use value comparers with different ordering ModificationCommandComparer could order concurrent command batches in a way that could cause a deadlock.

Making this work for all cases requires the ProviderValueComparer to implement IComparer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-save-changes type-enhancement
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@ajcvickers @AndriySvyryd