Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests in DEBUG in CI (in addition to RELEASE) #28147

Closed
roji opened this issue Jun 2, 2022 · 1 comment
Closed

Run tests in DEBUG in CI (in addition to RELEASE) #28147

roji opened this issue Jun 2, 2022 · 1 comment
Labels
closed-no-further-action The issue is closed and no further action is planned.

Comments

@roji
Copy link
Member

roji commented Jun 2, 2022

Our CI runs tests in RELEASE, since that's what we release to users. However, we have various additional DEBUG-only checks and asserts in the codebase, and it's important these get evaluated in CI as well.

We can add an additional build for DEBUG, or maybe leave Helix in Release and make the non-Helix build run in DEBUG?

@ajcvickers
Copy link
Member

Note from triage: developers frequently run the tests in Debug mode which should catch any issues relatively quickly, and we don't want to either lose any platform/environment coverage for testing what we actually ship, or add new runs since the C.I. system is already painfully slow.

@ajcvickers ajcvickers added closed-no-further-action The issue is closed and no further action is planned. and removed type-enhancement area-infrastructure labels Jun 8, 2022
@ajcvickers ajcvickers closed this as not planned Won't fix, can't repro, duplicate, stale Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-no-further-action The issue is closed and no further action is planned.
Projects
None yet
Development

No branches or pull requests

2 participants