Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use reference counting to determine what members added by convention should be removed #2869

Closed
AndriySvyryd opened this issue Aug 18, 2015 · 1 comment
Labels

Comments

@AndriySvyryd
Copy link
Member

Currently we do an explicit graph traversal to find if there are any references to the given member and remove it if there aren't. This could lead to an incorrect removal if the traversal is triggered by a convention invoked while a reference to the given member is being added.
The current method also doesn't recalculate the ConfigurationSource if a reference is removed (e.g. if an explicit relationship to a conventional entity type is removed the entity type will remain marked as added explicitly). This could lead to some orphan members not being removed.

@AndriySvyryd AndriySvyryd self-assigned this Aug 18, 2015
@rowanmiller rowanmiller added this to the 7.0.0 milestone Aug 21, 2015
@rowanmiller rowanmiller modified the milestones: 7.0.0-rc1, 7.0.0 Sep 17, 2015
@rowanmiller rowanmiller modified the milestones: 7.0.0, 7.0.0-rc1 Oct 14, 2015
@AndriySvyryd AndriySvyryd self-assigned this Dec 1, 2015
@rowanmiller
Copy link
Contributor

We will do this as part of #214 if we determine that it is needed when we implement that feature

@AndriySvyryd AndriySvyryd removed this from the 1.0.0 milestone Mar 4, 2016
@AndriySvyryd AndriySvyryd removed their assignment Jun 13, 2017
@ajcvickers ajcvickers reopened this Oct 16, 2022
@ajcvickers ajcvickers closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants