Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JsonScalarExpression: Remove jsonColumnMadeNullable #28887

Open
smitpatel opened this issue Aug 25, 2022 · 0 comments
Open

JsonScalarExpression: Remove jsonColumnMadeNullable #28887

smitpatel opened this issue Aug 25, 2022 · 0 comments
Labels
area-query type-cleanup
Milestone
MQ

Comments

@smitpatel
Copy link
Contributor

We shouldn't be checking if JSON column was made nullable in VisitChildren. If a visitor changes nullability, they are responsible for calling MakeNullable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-query type-cleanup
Projects
None yet
Milestone
MQ
Development

No branches or pull requests
2 participants
@ajcvickers @smitpatel