Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Batch" together delete (and possibly update) operations in seeding #28956

Open
roji opened this issue Sep 1, 2022 · 1 comment
Open

"Batch" together delete (and possibly update) operations in seeding #28956

roji opened this issue Sep 1, 2022 · 1 comment
Labels
area-migrations-seeding type-enhancement
Milestone
Backlog

Comments

@roji
Copy link
Member

roji commented Sep 1, 2022

MigrationsModelDiffer.GetDataOperations "batches" together multiple inserts to the same table, so that the scaffolded migration code looks much more readable (one insert operation with a big array instead of lots of single-row insert operations).

We could do the same for deletes, and possibly even for updates, as long as the column list is the same (not sure it's worth it).
@roji roji mentioned this issue Sep 1, 2022
Merged
@AndriySvyryd
Copy link
Member

Related: #3928

@ajcvickers ajcvickers added this to the Backlog milestone Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-migrations-seeding type-enhancement
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@ajcvickers @roji @AndriySvyryd