Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotate the 1st part of the query pipeline for trimming #32734

Open
Tracked by #34446 ...
roji opened this issue Jan 5, 2024 · 0 comments
Open
Tracked by #34446 ...

Annotate the 1st part of the query pipeline for trimming #32734

roji opened this issue Jan 5, 2024 · 0 comments

Comments

@roji
Copy link
Member

roji commented Jan 5, 2024

For NativeAOT, the 1st part of the query pipeline is not necessary and should in fact get trimmed away, since queries get precompiled out of runtime. This will also happen automatically, assuming the entry point(s) to the pipeline are enclosed in an RuntimeFeature.IsDynamicCodeSupported check.

However, when using trimming without NativeAOT, that code would still be referenced, and needs to be properly annotated in order to stop it from generating trimming warnings. Trimming without NativeAOT is actually a valuable scenario (contrary to what I thought), with "ReadyToRun + Trimmed + SingleFile" (significant file size/memory foorprint/startup time reduction, but without the runtime perf hit associated with NativeAOT, because of dynamic PGO). So we should ideally annotate the query pipeline for trimming for this case.

/cc @eerhardt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants