Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React to deps.json change wrt PrivateAssets #35265

Open
AndriySvyryd opened this issue Dec 3, 2024 · 2 comments
Open

React to deps.json change wrt PrivateAssets #35265

AndriySvyryd opened this issue Dec 3, 2024 · 2 comments

Comments

@AndriySvyryd
Copy link
Member

dotnet/sdk#45259 removes PackageReferences and ProjectReferences with PrivateAssets="all" from the deps.json. This means that transitive EFCore.Design references will no longer be discovered by our tools.

@AndriySvyryd
Copy link
Member Author

@bricelam If that change does go through, I'm not sure that there's much that we can do other than documenting that EFCore.Design should be referenced directly from every project that would be targeted by tools.

@AndriySvyryd AndriySvyryd added this to the 10.0.0 milestone Dec 3, 2024
@bricelam
Copy link
Contributor

bricelam commented Dec 3, 2024

Using AssemblyLoadContext (mentioned in #18840) would be an alternative to calling dotnet exec with the project's .deps.json file. This would allow us (Edit: lol, I can't help myself; it just comes out. I mean you guys) to define where it gets loaded from.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants