-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query: Allow store types and type facets to be set explicitly (EF.StoreType) #4978
Comments
Also cases of SqlFunction like CharIndex (comes from String.Contains method) the argument should have same type mapping. Though That could be different for individual functions. |
|
See also comments in #11921 |
See also comments in the thread here: #6717 (comment) |
Another issue which shows the need for a way to explicitly specify a store type: npgsql/efcore.pg#561. |
I am using EF Core 2.0.3 and I am getting the same issue for Contains search. Do you have any fix for that? |
blocked on #13192 |
I added a mechanism for query translators to provide explicit type mappings for function arguments and results in PR #13648. This allows us to fix individual cases. |
Another possible need for this: setting facets in order to allow something to participate in a set operation (currently set operations over types with differing facets isn't supported, #19129). |
Note that this issue has been a bit ambiguous; we can use this issue to track explicitly forcing a type mapping on an arbitrary node, whereas #35045 is about adding an actual |
#4937 introduced logic to infer Unicode-ness for literals when comparing to column. It works well for simple cases when one side of comparison is ColumnExpression. Though there are complex cases in which we are not inferring the information correctly atm. For e.g.
Non_unicode_string_literals_is_used_for_non_unicode_column_with_concat
)For cases like above, we can improve logic to propagate information. If it is too hard to do then we should add functions like
AsUnicode
&AsNonUnicode
.The text was updated successfully, but these errors were encountered: