Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PERF: Omit SELECT @@ROWCOUNT; when we are executing just a single statement #7037

Open
Tracked by #14496
anpete opened this issue Nov 17, 2016 · 2 comments
Open
Tracked by #14496

PERF: Omit SELECT @@ROWCOUNT; when we are executing just a single statement #7037

anpete opened this issue Nov 17, 2016 · 2 comments
Assignees
@roji
Labels
area-perf area-save-changes punted-for-2.0 type-enhancement
Milestone
Backlog

Comments

@anpete
Copy link
Contributor

anpete commented Nov 17, 2016

Should be able to use ExecuteCommand and check rowsAffected instead of ExecuteReader.
@divega divega added this to the 1.2.0 milestone Nov 18, 2016
@ajcvickers ajcvickers modified the milestones: Backlog, 2.0.0 Apr 17, 2017
@ajcvickers
Copy link
Contributor

If we decide to do this, let's check it will make an actual perf difference.

@bricelam bricelam mentioned this issue Sep 13, 2017
Closed
10 tasks
@AndriySvyryd AndriySvyryd mentioned this issue Oct 6, 2017
Open
@AndriySvyryd AndriySvyryd mentioned this issue Mar 17, 2022
Open
12 tasks
@AndriySvyryd AndriySvyryd assigned roji and unassigned AndriySvyryd Oct 19, 2022
@roji
Copy link
Member

roji commented Oct 19, 2022

Shouldn't make any meaningful difference, but we can confirm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roji roji

Labels
area-perf area-save-changes punted-for-2.0 type-enhancement
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
5 participants
@anpete @divega @ajcvickers @roji @AndriySvyryd