Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing EF tools on WPF 4.5.2 project add references to AspNetCore.Hosting & AspNetCore.Http #7835

Closed
cdie opened this issue Mar 10, 2017 · 6 comments

Comments

@cdie
Copy link

cdie commented Mar 10, 2017

I've installed EF Core tools 1.1.0 on a WPF application, and after installation, I've 4 references to AspNetCore.

Is that mandatory ? It looks like installing some Asp thing within a WPF app, feels bad...
image

Further technical details

EF Core version: 1.1.1
Database Provider: Microsoft.EntityFrameworkCore.SqlServer
Operating system: Win 10
IDE: VS 2017

@ErikEJ
Copy link
Contributor

ErikEJ commented Mar 10, 2017

I think it is a well known issue, workaround it by installing the Tools in a separate (scratch) project.

@bricelam
Copy link
Contributor

This is by design since we can't differentiate between an ASP.NET Core project targeting .NET Framework and all other .NET Framework projects at the NuGet package level.

This is mitigated by us marking our package as a developmentDependency. This tells NuGet that these dependencies aren't part of the app and shouldn't be published/deployed with it.

@cdie
Copy link
Author

cdie commented Mar 10, 2017

@bricelam Hum, in my packages.config, this dependency are not marked as developmentDependency. See here :
image

Can I mark them by myslef directly with no incidence ?

@ErikEJ
Copy link
Contributor

ErikEJ commented Mar 10, 2017

@cdie NuGet version?

@bricelam
Copy link
Contributor

bricelam commented Mar 10, 2017

That's a limitation of packages.config; it doesn't transitively apply the attribute. Also, project.json and MSBuild <PackageReference> don't handle it on install and require a manual edit. (See NuGet/Home#4125)

But, from an EF perspective, we've done everything we can so that NuGet clients could do the right thing...

Can I mark them by myslef directly with no incidence?

Yes.

@bricelam
Copy link
Contributor

FYI, these may be going away in 2.0.0. (See #8326)

@ajcvickers ajcvickers reopened this Oct 16, 2022
@ajcvickers ajcvickers closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants