Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Scaffolding - can now use Identity on a byte property #8140

Closed
lajones opened this issue Apr 12, 2017 · 2 comments
Closed

Update Scaffolding - can now use Identity on a byte property #8140

lajones opened this issue Apr 12, 2017 · 2 comments
Assignees
@bricelam
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. punted-for-2.0 type-bug
Milestone
2.0.0

Comments

@lajones
Copy link
Contributor

lajones commented Apr 12, 2017

Previously EF did not allow the Identity strategy to be used on properties which had the data type byte.

We enforce this in SqlServerScaffoldingModelFactory by issuing a warning if we are trying to put Identity on a byte property.

Discussion with @ajcvickers resulted in discovery that EF no longer disallows this. So we should stop issuing the warning and just set UseSqlServerIdentityColumn() on that column as we do for other data types.
@ajcvickers ajcvickers added this to the 2.0.0 milestone Apr 12, 2017
@ajcvickers ajcvickers modified the milestones: Backlog, 2.0.0 Apr 17, 2017
@bricelam bricelam mentioned this issue Jun 8, 2017
Closed
@smitpatel smitpatel removed this from the Backlog milestone Jun 8, 2017
@ajcvickers ajcvickers assigned bricelam and unassigned lajones Jun 12, 2017
@ajcvickers ajcvickers added this to the 2.0.0 milestone Jun 12, 2017
@bricelam bricelam modified the milestones: 2.0.0, Backlog Jun 20, 2017
@bricelam
Copy link
Contributor

@smitpatel Do we get this for free now?

@smitpatel
Copy link
Contributor

The warning is gone. item 4 on #8688 was about that. I scratched that. We don't need to do anything extra for this issue. We can close this.

@bricelam bricelam removed this from the Backlog milestone Aug 11, 2017
@ajcvickers ajcvickers added this to the 2.0.0 milestone Aug 14, 2017
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Aug 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bricelam bricelam

Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. punted-for-2.0 type-bug
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
4 participants
@bricelam @ajcvickers @smitpatel @lajones