Query: Entity splitting support for regular entities #28425
Conversation
|
Hello @smitpatel! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
| @@ -596,7 +596,7 @@ public override void QF_Select_Correlated_Subquery_In_Anonymous_Nested_With_QF() | |||
| @"SELECT [o].[CustomerId], [o].[OrderDate] | |||
| FROM [Orders] AS [o] | |||
| INNER JOIN ( | |||
| SELECT [g].[OrderId] | |||
| SELECT [c].[Id], [c].[FirstName], [c].[LastName], [g].[OrderId], [g].[CustomerId], [g].[OrderDate] | |||
There was a problem hiding this comment.
Why are we selecting additional column now?
There was a problem hiding this comment.
side-effect of removing join tables
Earlier we did base processing for inner join which identified the column being used in join predicate and removed others if not used. The code for removal of join table, excludes the join predicate columns too so we can be sure to remove the table but as a side-effect, now we don't identify the columns used if none used.
This only affects the case where there is a inner join which is not contributing anything to result. If there is any single column used in actual result from inner join, we will trim it down.
There was a problem hiding this comment.
Same effect existed for Left join from TPT, we can consider in future if this is significant scenario for us to do something about it.
There was a problem hiding this comment.
Are you planning to address this case in the future?
|
Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:
These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check. Give feedback on thisFrom the bot dev teamWe've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments. Please reach out to us at fabricbotservices@microsoft.com to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin. |
smitpatel
force-pushed
the
smit/entitysplitting
branch
from
8cc78a6
to
a1cc24e
Compare
|
Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:
These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check. Give feedback on thisFrom the bot dev teamWe've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments. Please reach out to us at fabricbotservices@microsoft.com to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin. |
Part of #620