Validate that if any fragments use table sharing then the main fragments are mapped to the same table #29285
+68
−206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nts are mapped to the same table Fixes #29104
AndriySvyryd
force-pushed
the
Issue29104
branch
from
4a24149
to
748c596
Compare
ajcvickers
approved these changes
Oct 6, 2022
AndriySvyryd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29104
Customer Impact
When a split fragment is sharing the table with the main fragment of the principal type and the main fragment of the dependent type shares the table of a split fragment of the principal type then any attempt to insert a row will result in a circular dependency. This change adds model validation to fail early for this type of models.
Regression?
No. Entity splitting is a new feature.
Risk
Low. This change is constrained to model validation.
Verification
Added a test for the affected scenario.