Use YAML stages (#2162)

* Set DotNetValidationArtifactsCategory

* Remove DotNetValidationArtifactsCategory

Author: wtgodbe

azure-pipelines.yml

@@ -26,274 +26,284 @@ pr:
     include:
     - '*'
 
-jobs:
-- job: Code_check
-  displayName: Code check
-  workspace:
-    clean: all
-  pool:
-    vmImage: vs2017-win2016
-  steps:
-  - powershell: . ./activate.ps1; ./restore.cmd -ci; ./eng/scripts/CodeCheck.ps1 -ci
-    displayName: Run eng/scripts/CodeCheck.ps1
+stages:
+- stage: build
+  displayName: Build
+  jobs:
+  - job: Code_check
+    displayName: Code check
+    workspace:
+      clean: all
+    pool:
+      vmImage: vs2017-win2016
+    steps:
+    - powershell: . ./activate.ps1; ./restore.cmd -ci; ./eng/scripts/CodeCheck.ps1 -ci
+      displayName: Run eng/scripts/CodeCheck.ps1
 
-- template: /eng/common/templates/jobs/jobs.yml
-  parameters:
-    enableMicrobuild: true
-    enablePublishBuildArtifacts: true
-    enablePublishTestResults: true
-    enablePublishBuildAssets: true
-    enablePublishUsingPipelines: $(_PublishUsingPipelines)
-    enableTelemetry: true
-    helixRepo: aspnet/Extensions
-    jobs:
-    - job: Windows
-      pool:
-        ${{ if eq(variables['System.TeamProject'], 'public') }}:
-          name: NetCorePublic-Pool
-          queue: BuildPool.Windows.10.Amd64.VS2017.Open
-        ${{ if ne(variables['System.TeamProject'], 'public') }}:
-          name: NetCoreInternal-Pool
-          queue: BuildPool.Windows.10.Amd64.VS2017
-      variables:
-      # Only enable publishing in official builds.
-      - ${{ if and(ne(variables['System.TeamProject'], 'public'), notin(variables['Build.Reason'], 'PullRequest')) }}:
-        # DotNet-Blob-Feed provides: dotnetfeed-storage-access-key-1
-        # Publish-Build-Assets provides: MaestroAccessToken, BotAccount-dotnet-maestro-bot-PAT
-        - group: DotNet-Blob-Feed
-        - group: Publish-Build-Assets
-        - name: _OfficialBuildArgs
-          value: /p:DotNetSignType=$(_SignType)
-                 /p:TeamName=$(_TeamName)
-                 /p:DotNetPublishBlobFeedKey=$(dotnetfeed-storage-access-key-1)
-                 /p:DotNetPublishBlobFeedUrl=https://dotnetfeed.blob.core.windows.net/aspnet-extensions/index.json
-                 /p:DotNetPublishToBlobFeed=$(_DotNetPublishToBlobFeed)
-                 /p:DotNetPublishUsingPipelines=$(_PublishUsingPipelines)
-                 /p:DotNetArtifactsCategory=$(_DotNetArtifactsCategory)
-                 /p:OfficialBuildId=$(BUILD.BUILDNUMBER)
-      # else
-      - ${{ if or(eq(variables['System.TeamProject'], 'public'), in(variables['Build.Reason'], 'PullRequest')) }}:
-        - name: _OfficialBuildArgs
-          value: ''
-      strategy:
-        matrix:
-          ${{ if in(variables['Build.Reason'], 'PullRequest') }}:
-            Debug:
-              _BuildConfig: Debug
-              _SignType: test
-              _DotNetPublishToBlobFeed: false
-              _BuildArgs:
+  - template: /eng/common/templates/jobs/jobs.yml
+    parameters:
+      enableMicrobuild: true
+      enablePublishBuildArtifacts: true
+      enablePublishTestResults: true
+      enablePublishBuildAssets: true
+      enablePublishUsingPipelines: ${{ variables._PublishUsingPipelines }}
+      enableTelemetry: true
+      helixRepo: aspnet/Extensions
+      jobs:
+      - job: Windows
+        pool:
+          ${{ if eq(variables['System.TeamProject'], 'public') }}:
+            name: NetCorePublic-Pool
+            queue: BuildPool.Windows.10.Amd64.VS2017.Open
+          ${{ if ne(variables['System.TeamProject'], 'public') }}:
+            name: NetCoreInternal-Pool
+            queue: BuildPool.Windows.10.Amd64.VS2017
+        variables:
+        # Only enable publishing in official builds.
+        - ${{ if and(ne(variables['System.TeamProject'], 'public'), notin(variables['Build.Reason'], 'PullRequest')) }}:
+          # DotNet-Blob-Feed provides: dotnetfeed-storage-access-key-1
+          # Publish-Build-Assets provides: MaestroAccessToken, BotAccount-dotnet-maestro-bot-PAT
+          - group: DotNet-Blob-Feed
+          - group: Publish-Build-Assets
+          - name: _OfficialBuildArgs
+            value: /p:DotNetSignType=$(_SignType)
+                   /p:TeamName=$(_TeamName)
+                   /p:DotNetPublishBlobFeedKey=$(dotnetfeed-storage-access-key-1)
+                   /p:DotNetPublishBlobFeedUrl=https://dotnetfeed.blob.core.windows.net/aspnet-extensions/index.json
+                   /p:DotNetPublishToBlobFeed=$(_DotNetPublishToBlobFeed)
+                   /p:DotNetPublishUsingPipelines=$(_PublishUsingPipelines)
+                   /p:DotNetArtifactsCategory=$(_DotNetArtifactsCategory)
+                   /p:OfficialBuildId=$(BUILD.BUILDNUMBER)
+        # else
+        - ${{ if or(eq(variables['System.TeamProject'], 'public'), in(variables['Build.Reason'], 'PullRequest')) }}:
+          - name: _OfficialBuildArgs
+            value: ''
+        strategy:
+          matrix:
+            ${{ if in(variables['Build.Reason'], 'PullRequest') }}:
+              Debug:
+                _BuildConfig: Debug
+                _SignType: test
+                _DotNetPublishToBlobFeed: false
+                _BuildArgs:
 
-          Release:
-            _BuildConfig: Release
-            # PRs or external builds are not signed.
-            ${{ if or(eq(variables['System.TeamProject'], 'public'), in(variables['Build.Reason'], 'PullRequest')) }}:
-              _SignType: test
-              _DotNetPublishToBlobFeed: false
-            ${{ if and(ne(variables['System.TeamProject'], 'public'), notin(variables['Build.Reason'], 'PullRequest')) }}:
-              _SignType: real
-              _DotNetPublishToBlobFeed: true
-              _BuildArgs: $(_OfficialBuildArgs)
-      steps:
-      - checkout: self
-        clean: true
-      - task: NuGetCommand@2
-        displayName: 'Clear NuGet caches'
-        condition: succeeded()
-        inputs:
-          command: custom
-          arguments: 'locals all -clear'
-      - script: eng\common\cibuild.cmd -configuration $(_BuildConfig) -prepareMachine $(_BuildArgs)
-        displayName: Build and Publish
-      - script: eng\scripts\ci-flaky-tests.cmd -configuration $(_BuildConfig)
-        displayName: Run Flaky Tests
-        continueOnError: true
-      - powershell: eng\scripts\KillProcesses.ps1
-        displayName: Kill processes
-        condition: always()
-      - task: PublishTestResults@2
-        displayName: Publish Flaky Test Results
-        inputs:
-          testResultsFormat: 'xUnit'
-          testResultsFiles: '*.xml'
-          searchFolder: '$(Build.SourcesDirectory)/artifacts/TestResults/$(_BuildConfig)/Flaky'
-        continueOnError: true
-        condition: always()
-      - task: PublishBuildArtifacts@1
-        displayName: Upload TestResults
-        condition: always()
-        continueOnError: true
-        inputs:
-          pathtoPublish: artifacts/TestResults/$(_BuildConfig)/
-          artifactName: $(Agent.Os)_$(Agent.JobName) TestResults
-          artifactType: Container
-          parallel: true
-      - task: PublishBuildArtifacts@1
-        displayName: Upload package artifacts
-        condition: and(succeeded(), eq(variables['system.pullrequest.isfork'], false), eq(variables['_BuildConfig'], 'Release'))
-        inputs:
-          pathtoPublish: artifacts/packages/
-          artifactName: artifacts
-          artifactType: Container
-          parallel: true
+            Release:
+              _BuildConfig: Release
+              # PRs or external builds are not signed.
+              ${{ if or(eq(variables['System.TeamProject'], 'public'), in(variables['Build.Reason'], 'PullRequest')) }}:
+                _SignType: test
+                _DotNetPublishToBlobFeed: false
+              ${{ if and(ne(variables['System.TeamProject'], 'public'), notin(variables['Build.Reason'], 'PullRequest')) }}:
+                _SignType: real
+                _DotNetPublishToBlobFeed: true
+                _BuildArgs: $(_OfficialBuildArgs)
+        steps:
+        - checkout: self
+          clean: true
+        - task: NuGetCommand@2
+          displayName: 'Clear NuGet caches'
+          condition: succeeded()
+          inputs:
+            command: custom
+            arguments: 'locals all -clear'
+        - script: eng\common\cibuild.cmd -configuration $(_BuildConfig) -prepareMachine $(_BuildArgs)
+          displayName: Build and Publish
+        - script: eng\scripts\ci-flaky-tests.cmd -configuration $(_BuildConfig)
+          displayName: Run Flaky Tests
+          continueOnError: true
+        - powershell: eng\scripts\KillProcesses.ps1
+          displayName: Kill processes
+          condition: always()
+        - task: PublishTestResults@2
+          displayName: Publish Flaky Test Results
+          inputs:
+            testResultsFormat: 'xUnit'
+            testResultsFiles: '*.xml'
+            searchFolder: '$(Build.SourcesDirectory)/artifacts/TestResults/$(_BuildConfig)/Flaky'
+          continueOnError: true
+          condition: always()
+        - task: PublishBuildArtifacts@1
+          displayName: Upload TestResults
+          condition: always()
+          continueOnError: true
+          inputs:
+            pathtoPublish: artifacts/TestResults/$(_BuildConfig)/
+            artifactName: $(Agent.Os)_$(Agent.JobName) TestResults
+            artifactType: Container
+            parallel: true
+        - task: PublishBuildArtifacts@1
+          displayName: Upload package artifacts
+          condition: and(succeeded(), eq(variables['system.pullrequest.isfork'], false), eq(variables['_BuildConfig'], 'Release'))
+          inputs:
+            pathtoPublish: artifacts/packages/
+            artifactName: artifacts
+            artifactType: Container
+            parallel: true
 
-    - job: Ubuntu_16_04
-      displayName: 'Ubuntu 16.04'
-      pool:
-        vmImage: ubuntu-16.04
-      variables:
-      # Only enable publishing in official builds.
-      - ${{ if and(eq(variables['System.TeamProject'], 'internal'), notin(variables['Build.Reason'], 'PullRequest')) }}:
-        - name: _OfficialBuildArgs
-          value: -p:OfficialBuildId=$(Build.BuildNumber)
-      # else
-      - ${{ if or(eq(variables['System.TeamProject'], 'public'), in(variables['Build.Reason'], 'PullRequest')) }}:
-        - name: _OfficialBuildArgs
-          value: ''
-      strategy:
-        matrix:
-          ${{ if in(variables['Build.Reason'], 'PullRequest') }}:
-            Debug:
-              _BuildConfig: Debug
+      - job: Ubuntu_16_04
+        displayName: 'Ubuntu 16.04'
+        pool:
+          vmImage: ubuntu-16.04
+        variables:
+        # Only enable publishing in official builds.
+        - ${{ if and(eq(variables['System.TeamProject'], 'internal'), notin(variables['Build.Reason'], 'PullRequest')) }}:
+          - name: _OfficialBuildArgs
+            value: -p:OfficialBuildId=$(Build.BuildNumber)
+        # else
+        - ${{ if or(eq(variables['System.TeamProject'], 'public'), in(variables['Build.Reason'], 'PullRequest')) }}:
+          - name: _OfficialBuildArgs
+            value: ''
+        strategy:
+          matrix:
+            ${{ if in(variables['Build.Reason'], 'PullRequest') }}:
+              Debug:
+                _BuildConfig: Debug
+                _SignType: none
+                _DotNetPublishToBlobFeed : false
+            Release:
+              _BuildConfig: Release
               _SignType: none
               _DotNetPublishToBlobFeed : false
-          Release:
-            _BuildConfig: Release
-            _SignType: none
-            _DotNetPublishToBlobFeed : false
-      steps:
-      - checkout: self
-        clean: true
-      - task: NodeTool@0
-        displayName: Install Node 10.x
-        inputs:
-          versionSpec: 10.x
-      - script: eng/common/cibuild.sh
-          --configuration $(_BuildConfig)
-          --prepareMachine
-          -p:BuildNodeJS=true
-          $(_OfficialBuildArgs)
-        displayName: Build
-      - script: eng/scripts/ci-flaky-tests.sh --configuration $(_BuildConfig)
-        displayName: Run Flaky Tests
-        continueOnError: true
-      - script: eng/scripts/KillProcesses.sh
-        displayName: Kill processes
-        condition: always()
-      - task: PublishTestResults@2
-        displayName: Publish Flaky Test Results
-        inputs:
-          testResultsFormat: 'xUnit'
-          testResultsFiles: '*.xml'
-          searchFolder: '$(Build.SourcesDirectory)/artifacts/TestResults/$(_BuildConfig)/Flaky'
-        continueOnError: true
-        condition: always()
-      - task: PublishBuildArtifacts@1
-        displayName: Upload TestResults
-        condition: always()
-        continueOnError: true
-        inputs:
-          pathtoPublish: artifacts/TestResults/$(_BuildConfig)/
-          artifactName: $(Agent.Os)_$(Agent.JobName) TestResults
-          artifactType: Container
-          parallel: true
-      - task: PublishBuildArtifacts@1
-        displayName: Upload NPM artifacts
-        condition: and(succeeded(), eq(variables['_BuildConfig'], 'Release'))
-        inputs:
-          pathtoPublish: artifacts/npm/
-          artifactName: NpmArtifacts
-          artifactType: Container
-          parallel: true
+        steps:
+        - checkout: self
+          clean: true
+        - task: NodeTool@0
+          displayName: Install Node 10.x
+          inputs:
+            versionSpec: 10.x
+        - script: eng/common/cibuild.sh
+            --configuration $(_BuildConfig)
+            --prepareMachine
+            -p:BuildNodeJS=true
+            $(_OfficialBuildArgs)
+          displayName: Build
+        - script: eng/scripts/ci-flaky-tests.sh --configuration $(_BuildConfig)
+          displayName: Run Flaky Tests
+          continueOnError: true
+        - script: eng/scripts/KillProcesses.sh
+          displayName: Kill processes
+          condition: always()
+        - task: PublishTestResults@2
+          displayName: Publish Flaky Test Results
+          inputs:
+            testResultsFormat: 'xUnit'
+            testResultsFiles: '*.xml'
+            searchFolder: '$(Build.SourcesDirectory)/artifacts/TestResults/$(_BuildConfig)/Flaky'
+          continueOnError: true
+          condition: always()
+        - task: PublishBuildArtifacts@1
+          displayName: Upload TestResults
+          condition: always()
+          continueOnError: true
+          inputs:
+            pathtoPublish: artifacts/TestResults/$(_BuildConfig)/
+            artifactName: $(Agent.Os)_$(Agent.JobName) TestResults
+            artifactType: Container
+            parallel: true
+        - task: PublishBuildArtifacts@1
+          displayName: Upload NPM artifacts
+          condition: and(succeeded(), eq(variables['_BuildConfig'], 'Release'))
+          inputs:
+            pathtoPublish: artifacts/npm/
+            artifactName: NpmArtifacts
+            artifactType: Container
+            parallel: true
 
-    - job: OSX_10_13
-      displayName: 'OSX'
-      pool:
-        vmImage: macOS-10.13
-      strategy:
-        matrix:
-          ${{ if in(variables['Build.Reason'], 'PullRequest') }}:
-            Debug:
-              _BuildConfig: Debug
+      - job: OSX_10_13
+        displayName: 'OSX'
+        pool:
+          vmImage: macOS-10.13
+        strategy:
+          matrix:
+            ${{ if in(variables['Build.Reason'], 'PullRequest') }}:
+              Debug:
+                _BuildConfig: Debug
+                _SignType: none
+                _DotNetPublishToBlobFeed : false
+            Release:
+              _BuildConfig: Release
               _SignType: none
               _DotNetPublishToBlobFeed : false
-          Release:
-            _BuildConfig: Release
-            _SignType: none
-            _DotNetPublishToBlobFeed : false
-      steps:
-      - checkout: self
-        clean: true
-      - script: eng/common/cibuild.sh
-          --configuration $(_BuildConfig)
-          --prepareMachine
-        displayName: Build
-      - script: eng/scripts/ci-flaky-tests.sh --configuration $(_BuildConfig)
-        displayName: Run Flaky Tests
-        continueOnError: true
-      - script: eng/scripts/KillProcesses.sh
-        displayName: Kill processes
-        condition: always()
-      - task: PublishTestResults@2
-        displayName: Publish Flaky Test Results
-        inputs:
-          testResultsFormat: 'xUnit'
-          testResultsFiles: '*.xml'
-          searchFolder: '$(Build.SourcesDirectory)/artifacts/TestResults/$(_BuildConfig)/Flaky'
-        continueOnError: true
-        condition: always()
-      - task: PublishBuildArtifacts@1
-        displayName: Upload TestResults
-        condition: always()
-        continueOnError: true
-        inputs:
-          pathtoPublish: artifacts/TestResults/$(_BuildConfig)/
-          artifactName: $(Agent.Os)_$(Agent.JobName) TestResults
-          artifactType: Container
-          parallel: true
-- job: Source_Build
-  displayName: 'Test: Linux Source Build'
-  container: centos:7
-  pool:
-    vmImage: 'ubuntu-16.04'
-  variables:
-    DotNetCoreSdkDir: $(Agent.ToolsDirectory)/dotnet
-    DOTNET_SYSTEM_GLOBALIZATION_INVARIANT: true
-  steps:
-  - script: |
-      source eng/common/native/common-library.sh
-      mkdir -p $HOME/bin
-      GetFile https://github.com/stedolan/jq/releases/download/jq-1.6/jq-linux64 $HOME/bin/jq
-      chmod +x $HOME/bin/jq
-      echo "##vso[task.prependpath]$HOME/bin"
-    displayName: Install jq
-  - task: UseDotNet@2
-    displayName: 'Use .NET Core sdk'
-    inputs:
-      packageType: sdk
-      # The SDK version selected here is intentionally supposed to use the latest release
-      # For the purpose of building Linux distros, we can't depend on features of the SDK
-      # which may not exist in pre-built versions of the SDK
-      version: 3.0.x
-      installationPath: $(DotNetCoreSdkDir)
-      includePreviewVersions: true
-  - script: ./eng/scripts/ci-source-build.sh --ci --configuration Release
-    displayName: Run ci-source-build.sh
-  - task: PublishBuildArtifacts@1
-    displayName: Upload logs
-    continueOnError: true
-    inputs:
-      pathtoPublish: artifacts/log/
-      artifactName: Source_Build_Logs
-      artifactType: Container
-      parallel: true
-  - task: PublishBuildArtifacts@1
-    displayName: Upload package artifacts
-    # Only capture source build artifacts in PRs for the sake of inspecting
-    # changes that impact source-build. The artifacts from this build pipeline are never actually used.
-    condition: and(succeeded(), eq(variables['Build.Reason'], 'PullRequest'))
-    inputs:
-      pathtoPublish: artifacts/packages/
-      artifactName: Source_Build_Packages
-      artifactType: Container
-      parallel: true
+        steps:
+        - checkout: self
+          clean: true
+        - script: eng/common/cibuild.sh
+            --configuration $(_BuildConfig)
+            --prepareMachine
+          displayName: Build
+        - script: eng/scripts/ci-flaky-tests.sh --configuration $(_BuildConfig)
+          displayName: Run Flaky Tests
+          continueOnError: true
+        - script: eng/scripts/KillProcesses.sh
+          displayName: Kill processes
+          condition: always()
+        - task: PublishTestResults@2
+          displayName: Publish Flaky Test Results
+          inputs:
+            testResultsFormat: 'xUnit'
+            testResultsFiles: '*.xml'
+            searchFolder: '$(Build.SourcesDirectory)/artifacts/TestResults/$(_BuildConfig)/Flaky'
+          continueOnError: true
+          condition: always()
+        - task: PublishBuildArtifacts@1
+          displayName: Upload TestResults
+          condition: always()
+          continueOnError: true
+          inputs:
+            pathtoPublish: artifacts/TestResults/$(_BuildConfig)/
+            artifactName: $(Agent.Os)_$(Agent.JobName) TestResults
+            artifactType: Container
+            parallel: true
+  - job: Source_Build
+    displayName: 'Test: Linux Source Build'
+    container: centos:7
+    pool:
+      vmImage: 'ubuntu-16.04'
+    variables:
+      DotNetCoreSdkDir: $(Agent.ToolsDirectory)/dotnet
+      DOTNET_SYSTEM_GLOBALIZATION_INVARIANT: true
+    steps:
+    - script: |
+        source eng/common/native/common-library.sh
+        mkdir -p $HOME/bin
+        GetFile https://github.com/stedolan/jq/releases/download/jq-1.6/jq-linux64 $HOME/bin/jq
+        chmod +x $HOME/bin/jq
+        echo "##vso[task.prependpath]$HOME/bin"
+      displayName: Install jq
+    - task: UseDotNet@2
+      displayName: 'Use .NET Core sdk'
+      inputs:
+        packageType: sdk
+        # The SDK version selected here is intentionally supposed to use the latest release
+        # For the purpose of building Linux distros, we can't depend on features of the SDK
+        # which may not exist in pre-built versions of the SDK
+        version: 3.0.x
+        installationPath: $(DotNetCoreSdkDir)
+        includePreviewVersions: true
+    - script: ./eng/scripts/ci-source-build.sh --ci --configuration Release
+      displayName: Run ci-source-build.sh
+    - task: PublishBuildArtifacts@1
+      displayName: Upload logs
+      continueOnError: true
+      inputs:
+        pathtoPublish: artifacts/log/
+        artifactName: Source_Build_Logs
+        artifactType: Container
+        parallel: true
+    - task: PublishBuildArtifacts@1
+      displayName: Upload package artifacts
+      # Only capture source build artifacts in PRs for the sake of inspecting
+      # changes that impact source-build. The artifacts from this build pipeline are never actually used.
+      condition: and(succeeded(), eq(variables['Build.Reason'], 'PullRequest'))
+      inputs:
+        pathtoPublish: artifacts/packages/
+        artifactName: Source_Build_Packages
+        artifactType: Container
+        parallel: true
+
+- ${{ if and(ne(variables['System.TeamProject'], 'public'), notin(variables['Build.Reason'], 'PullRequest')) }}:
+  - template: eng\common\templates\post-build\post-build.yml
+    parameters:
+      # Symbol validation isn't being very reliable lately. This should be enabled back
+      # once this issue is resolved: https://github.com/dotnet/arcade/issues/2871
+      enableSymbolValidation: false