Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retire IResourceMonitorPublisher in favor of observable instruments #4404

Closed
geeknoid opened this issue Sep 13, 2023 · 3 comments · Fixed by #5360
Closed

Retire IResourceMonitorPublisher in favor of observable instruments #4404

geeknoid opened this issue Sep 13, 2023 · 3 comments · Fixed by #5360
Assignees
Labels
area-fundamentals enhancement This issue represents an ask for new feature or an enhancement to an existing one work in progress 🚧

Comments

@geeknoid
Copy link
Member

We can simplify and unify the resource monitoring API to have it produce observable instruments in place of the existing IResourceMonitorPublisher API.

@geeknoid geeknoid added enhancement This issue represents an ask for new feature or an enhancement to an existing one and removed untriaged labels Nov 27, 2023
@evgenyfedorov2
Copy link
Contributor

@geeknoid Is this issue still relevant and if yes, what is the plan here? Just put the Obsolete attributes on the publisher's API and call it a day? We can't make breaking changes and have to support all existing APIs forever, right?

@geeknoid
Copy link
Member Author

Correct, no breaking changes allowed. So if we add the logic to produce observable instruments, we'd keep the old stuff and add ]Obsolete] as you say.

@noahfalk
Copy link
Member

In case folks weren't already aware I want to call out that .NET 9 added runtime metrics using the Meter API which includes a few CPU and memory metrics. It doesn't cover everything these resource monitoring metrics do but I suspect there is some overlap. The metrics got merged a few weeks ago and I am just getting the docs for it up now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-fundamentals enhancement This issue represents an ask for new feature or an enhancement to an existing one work in progress 🚧
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants