-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dotnet/extensions metric names to follow some convention #4432
Comments
As @noahfalk suggested, we should consider using instrument names that follow pattern like: |
I can apply this pattern within #4342, but we need to reach an agreement first |
We have also aligned the naming in Polly with OpenTelemetry by using the convention as suggested above. See App-vNext/Polly#1583 for reference. Also attributes names were changed:
|
Up-to-date conventions are here: https://github.com/open-telemetry/semantic-conventions/blob/main/docs/general/metrics.md |
@xakep139 is working on this this week, and the target is to merge by next week. |
Update:
|
Currently, the metric names are using backslashes. OTel uses dots. We need to go through the metrics and ensure we stick to the same naming convention (and semantic grouping as part of the metric name).
Proposal:
The text was updated successfully, but these errors were encountered: