Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for primary constructors in our Logging generator #5178

Closed
joperezr opened this issue May 23, 2024 · 1 comment · Fixed by #5370
Closed

Add support for primary constructors in our Logging generator #5178

joperezr opened this issue May 23, 2024 · 1 comment · Fixed by #5370
Assignees
@dariusclay
Labels
area-telemetry enhancement This issue represents an ask for new feature or an enhancement to an existing one

Comments

@joperezr
Copy link
Member

For more info, look a this PR: dotnet/runtime#101660

cc: @tarekgh
@joperezr joperezr mentioned this issue May 23, 2024
Merged
@geeknoid geeknoid added the enhancement This issue represents an ask for new feature or an enhancement to an existing one label May 28, 2024
@dariusclay dariusclay self-assigned this Aug 17, 2024
@dariusclay
Copy link
Contributor

This will be fixed in #5370

@dariusclay dariusclay linked a pull request Aug 17, 2024 that will close this issue
Bring parity to dotnet extensions logging generator behavior #5370
Merged
4 tasks
@dariusclay dariusclay mentioned this issue Aug 27, 2024
Merged
4 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dariusclay dariusclay

Labels
area-telemetry enhancement This issue represents an ask for new feature or an enhancement to an existing one
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bring parity to dotnet extensions logging generator behavior dotnet/extensions
4 participants
@dariusclay @RussKie @joperezr @geeknoid