Skip to content

Commit 1f8612b

Browse files
committed
Fix for codeplex issue 201:
Enabling warnings as errors for all projects causes ProjectSystem.Base to fail to build. In both master and fsharp 4. "C:\visualfsharp\vsintegration\fsharp-vsintegration-build.proj" (default target) (1) -> "C:\visualfsharp\vsintegration\src\Deployment.sln" (Build target) (2) -> "C:\visualfsharp\vsintegration\src\deployment\EnableOpenSource\EnableOpenSource.csproj" (default target) (3) -> "C:\visualfsharp\vsintegration\src\vs\FsPkgs\FSharp.Project\Common.Source.CSharp\Project\ProjectSystem.Base.csproj" (default target) (12) -> (CoreCompile target) -> DataObject.cs(431,37): error CS8073: The result of the expression is always 'true' since a value of type 'IntPtr' is never equal to 'null' of type 'IntPtr?' [C:\visualfsharp\vsintegration\src\vs\FsPkgs\FSharp.Project\Common.Source.CSharp\Project\ ProjectSystem.Base.csproj] Use IntPtr.Zero instead of null (changeset 1391801)
1 parent 5c51d49 commit 1f8612b

File tree

1 file changed

+1
-1
lines changed
  • vsintegration/src/vs/FsPkgs/FSharp.Project/Common.Source.CSharp/Project

1 file changed

+1
-1
lines changed

vsintegration/src/vs/FsPkgs/FSharp.Project/Common.Source.CSharp/Project/DataObject.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -428,7 +428,7 @@ public static string GetSourceProjectPath(Microsoft.VisualStudio.OLE.Interop.IDa
428428
}
429429
finally
430430
{
431-
if (data != null)
431+
if (data != IntPtr.Zero)
432432
{
433433
UnsafeNativeMethods.GlobalUnLock(data);
434434
}

0 commit comments

Comments
 (0)