Skip to content

Commit 3b2086c

Browse files
authored
Release notest tweaks (#16479)
1 parent 7760da2 commit 3b2086c

File tree

1 file changed

+15
-10
lines changed

1 file changed

+15
-10
lines changed

.github/workflows/check_release_notes.yml

Lines changed: 15 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -133,19 +133,19 @@ jobs:
133133
134134
if [[ ${_pr_link_occurences} -eq 1 ]]; then
135135
echo " Found pull request URL in $release_notes once"
136-
RELEASE_NOTES_FOUND+="> | \\\`$path\\\` | [$release_notes](${FSHARP_REPO_URL}/$release_notes) | |"
136+
RELEASE_NOTES_FOUND+="> | \\\`$path\\\` | [$release_notes](${FSHARP_REPO_URL}/tree/main/$release_notes) | |"
137137
RELEASE_NOTES_FOUND+=$'\n'
138138
elif [[ ${_pr_link_occurences} -eq 0 ]]; then
139139
echo " Did not find pull request URL in $release_notes"
140140
DESCRIPTION="**No current pull request URL (${PR_URL}) found, please consider adding it**"
141-
RELEASE_NOTES_FOUND+="> | \\\`$path\\\` | [$release_notes](${FSHARP_REPO_URL}/$release_notes) | ${DESCRIPTION} |"
141+
RELEASE_NOTES_FOUND+="> | \\\`$path\\\` | [$release_notes](${FSHARP_REPO_URL}/tree/main/$release_notes) | ${DESCRIPTION} |"
142142
RELEASE_NOTES_FOUND+=$'\n'
143143
PULL_REQUEST_FOUND=false
144144
fi
145145
else
146146
echo " Did not find $release_notes in modified files"
147147
DESCRIPTION="**No release notes found or release notes format is not correct**"
148-
RELEASE_NOTES_NOT_FOUND+="| \\\`$path\\\` | [$release_notes](${FSHARP_REPO_URL}/$release_notes) | ${DESCRIPTION} |"
148+
RELEASE_NOTES_NOT_FOUND+="| \\\`$path\\\` | [$release_notes](${FSHARP_REPO_URL}/tree/main/$release_notes) | ${DESCRIPTION} |"
149149
RELEASE_NOTES_NOT_FOUND+=$'\n'
150150
fi
151151
else
@@ -161,24 +161,29 @@ jobs:
161161
RELEASE_NOTES_MESSAGE_DETAILS+=$'\n'
162162
RELEASE_NOTES_MESSAGE_DETAILS+=$"> [!CAUTION]"
163163
RELEASE_NOTES_MESSAGE_DETAILS+=$'\n'
164-
RELEASE_NOTES_MESSAGE_DETAILS+=$"> **No release notes found for the following paths.**"
164+
RELEASE_NOTES_MESSAGE_DETAILS+=$"> **No release notes found for the changed paths (see table below).**"
165165
RELEASE_NOTES_MESSAGE_DETAILS+=$'\n'
166166
RELEASE_NOTES_MESSAGE_DETAILS+=$">"
167167
RELEASE_NOTES_MESSAGE_DETAILS+=$'\n'
168-
RELEASE_NOTES_MESSAGE_DETAILS+=$"> Please make sure to add an entry with short succint description of the change as well as link to this pull request."
168+
RELEASE_NOTES_MESSAGE_DETAILS+=$"> Please make sure to add an entry with an informative description of the change as well as link to this pull request, issue and language suggestion if applicable. Release notes for this repository are based on [Keep A Changelog](https://keepachangelog.com/en/1.1.0/) format."
169169
RELEASE_NOTES_MESSAGE_DETAILS+=$'\n'
170170
RELEASE_NOTES_MESSAGE_DETAILS+=$">"
171171
RELEASE_NOTES_MESSAGE_DETAILS+=$'\n'
172-
RELEASE_NOTES_MESSAGE_DETAILS+=$"> Examples: "
172+
RELEASE_NOTES_MESSAGE_DETAILS+=$"> **The following format is recommended for this repository:**"
173173
RELEASE_NOTES_MESSAGE_DETAILS+=$'\n'
174-
RELEASE_NOTES_MESSAGE_DETAILS+=$"> \\\`- Respect line limit in quick info popup - https://github.com/dotnet/fsharp/pull/16208\\\`"
174+
RELEASE_NOTES_MESSAGE_DETAILS+=$">"
175+
RELEASE_NOTES_MESSAGE_DETAILS+=$'\n'
176+
RELEASE_NOTES_MESSAGE_DETAILS+=$">"
175177
RELEASE_NOTES_MESSAGE_DETAILS+=$'\n'
176-
RELEASE_NOTES_MESSAGE_DETAILS+=$"> \\\`- More inlines for Result module - https://github.com/dotnet/fsharp/pull/16106\\\`"
178+
RELEASE_NOTES_MESSAGE_DETAILS+=$"> \\\`* <Informative description>. ([PR #XXXXX](https://github.com/dotnet/fsharp/pull/XXXXX))\\\`"
177179
RELEASE_NOTES_MESSAGE_DETAILS+=$'\n'
178-
RELEASE_NOTES_MESSAGE_DETAILS+=$"> \\\`- Miscellaneous fixes to parens analysis - https://github.com/dotnet/fsharp/pull/16262\\\`"
180+
RELEASE_NOTES_MESSAGE_DETAILS+=$">"
181+
RELEASE_NOTES_MESSAGE_DETAILS+=$'\n'
182+
RELEASE_NOTES_MESSAGE_DETAILS+=$">"
183+
RELEASE_NOTES_MESSAGE_DETAILS+=$"> See examples in the files, listed in the table below or in th full documentation at https://fsharp.github.io/fsharp-compiler-docs/release-notes/About.html."
179184
RELEASE_NOTES_MESSAGE_DETAILS+=$'\n'
180185
RELEASE_NOTES_MESSAGE_DETAILS+=$'\n'
181-
RELEASE_NOTES_MESSAGE_DETAILS+=$'**If you believe that release notes are not necessary for this PR, please add "NO_RELEASE_NOTES" label to the pull request.**'
186+
RELEASE_NOTES_MESSAGE_DETAILS+=$'**If you believe that release notes are not necessary for this PR, please add <kbd>NO_RELEASE_NOTES</kbd> label to the pull request.**'
182187
RELEASE_NOTES_MESSAGE_DETAILS+=$'\n'
183188
RELEASE_NOTES_MESSAGE_DETAILS+=$'\n'
184189
RELEASE_NOTES_MESSAGE_DETAILS+=$"**You can open this PR in browser to add release notes: [open in github.dev](https://github.dev/dotnet/fsharp/pull/${PR_NUMBER})**"

0 commit comments

Comments
 (0)