Skip to content

Commit cecb26e

Browse files
committed
adjust seq tests for better filering and sorting
1 parent f6d259d commit cecb26e

File tree

4 files changed

+132
-124
lines changed

4 files changed

+132
-124
lines changed

src/fsharp/FSharp.Core.Unittests/FSharp.Core/Microsoft.FSharp.Collections/CollectionModulesConsistency.fs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
// Copyright (c) Microsoft Corporation. All Rights Reserved. Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
2-
2+
[<NUnit.Framework.Parallelizable>]
3+
[<NUnit.Framework.Category "Collections Tests">]
4+
[<NUnit.Framework.Category "Seq Tests">]
5+
[<NUnit.Framework.TestFixture >]
36
module FSharp.Core.Unittests.FSharp_Core.Microsoft_FSharp_Collections.CollectionModulesConsistency
47

58
open System

src/fsharp/FSharp.Core.Unittests/FSharp.Core/Microsoft.FSharp.Collections/SeqModule.fs

Lines changed: 38 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,11 @@ Make sure each method works on:
1919
* Null Seq (null)
2020
*)
2121

22-
[<TestFixture>]
23-
type SeqModule() =
22+
[<Parallelizable>][<Category "Collections Tests">][<Category "Seq Tests">]
23+
module SeqModuleTests =
2424

2525
[<Test>]
26-
member this.AllPairs() =
26+
let AllPairs() =
2727

2828
// integer Seq
2929
let resultInt = Seq.allPairs (seq [1..7]) (seq [11..17])
@@ -50,7 +50,7 @@ type SeqModule() =
5050
()
5151

5252
[<Test>]
53-
member this.CachedSeq_Clear() =
53+
let CachedSeq_Clear() =
5454

5555
let evaluatedItems : int list ref = ref []
5656
let cachedSeq =
@@ -90,7 +90,7 @@ type SeqModule() =
9090
()
9191

9292
[<Test>]
93-
member this.Append() =
93+
let Append() =
9494

9595
// empty Seq
9696
let emptySeq1 = Seq.empty
@@ -135,7 +135,7 @@ type SeqModule() =
135135
()
136136

137137
[<Test>]
138-
member this.replicate() =
138+
let replicate() =
139139
// replicate should create multiple copies of the given value
140140
Assert.IsTrue(Seq.isEmpty <| Seq.replicate 0 null)
141141
Assert.IsTrue(Seq.isEmpty <| Seq.replicate 0 1)
@@ -146,7 +146,7 @@ type SeqModule() =
146146

147147

148148
[<Test>]
149-
member this.Average() =
149+
let Average() =
150150
// empty Seq
151151
let emptySeq:seq<double> = Seq.empty<double>
152152

@@ -182,7 +182,7 @@ type SeqModule() =
182182

183183

184184
[<Test>]
185-
member this.AverageBy() =
185+
let AverageBy() =
186186
// empty Seq
187187
let emptySeq:seq<double> = Seq.empty<double>
188188

@@ -216,7 +216,7 @@ type SeqModule() =
216216
()
217217

218218
[<Test>]
219-
member this.Cache() =
219+
let Cache() =
220220
// empty Seq
221221
let emptySeq:seq<double> = Seq.empty<double>
222222

@@ -257,7 +257,7 @@ type SeqModule() =
257257
()
258258

259259
[<Test>]
260-
member this.Case() =
260+
let Case() =
261261

262262
// integer Seq
263263
let integerArray = [|1;2|]
@@ -304,7 +304,7 @@ type SeqModule() =
304304
()
305305

306306
[<Test>]
307-
member this.Choose() =
307+
let Choose() =
308308

309309
// int Seq
310310
let intSeq = seq [1..20]
@@ -343,7 +343,7 @@ type SeqModule() =
343343
()
344344

345345
[<Test>]
346-
member this.ChunkBySize() =
346+
let ChunkBySize() =
347347

348348
let verify expected actual =
349349
Seq.zip expected actual
@@ -379,7 +379,7 @@ type SeqModule() =
379379
()
380380

381381
[<Test>]
382-
member this.SplitInto() =
382+
let SplitInto() =
383383

384384
let verify expected actual =
385385
Seq.zip expected actual
@@ -410,7 +410,7 @@ type SeqModule() =
410410
()
411411

412412
[<Test>]
413-
member this.Compare() =
413+
let Compare() =
414414

415415
// int Seq
416416
let intSeq1 = seq [1;3;7;9]
@@ -446,7 +446,7 @@ type SeqModule() =
446446
()
447447

448448
[<Test>]
449-
member this.Concat() =
449+
let Concat() =
450450
// integer Seq
451451
let seqInt =
452452
seq { for i in 0..9 do
@@ -482,7 +482,7 @@ type SeqModule() =
482482
()
483483

484484
[<Test>]
485-
member this.CountBy() =
485+
let CountBy() =
486486
// integer Seq
487487
let funcIntCount_by (x:int) = x%3
488488
let seqInt =
@@ -516,7 +516,7 @@ type SeqModule() =
516516
()
517517

518518
[<Test>]
519-
member this.Distinct() =
519+
let Distinct() =
520520

521521
// integer Seq
522522
let IntDistinctSeq =
@@ -550,7 +550,7 @@ type SeqModule() =
550550
()
551551

552552
[<Test>]
553-
member this.DistinctBy () =
553+
let DistinctBy () =
554554
// integer Seq
555555
let funcInt x = x % 3
556556
let IntDistinct_bySeq =
@@ -585,7 +585,7 @@ type SeqModule() =
585585
()
586586

587587
[<Test>]
588-
member this.Except() =
588+
let Except() =
589589
// integer Seq
590590
let intSeq1 = seq { yield! {1..100}
591591
yield! {1..100} }
@@ -624,7 +624,7 @@ type SeqModule() =
624624
()
625625

626626
[<Test>]
627-
member this.Exists() =
627+
let Exists() =
628628

629629
// Integer Seq
630630
let funcInt x = (x % 2 = 0)
@@ -659,7 +659,7 @@ type SeqModule() =
659659
()
660660

661661
[<Test>]
662-
member this.Exists2() =
662+
let Exists2() =
663663
// Integer Seq
664664
let funcInt x y = (x+y)%3=0
665665
let Intexists2Seq1 = seq [1;3;7]
@@ -687,7 +687,7 @@ type SeqModule() =
687687

688688

689689
[<Test>]
690-
member this.Filter() =
690+
let Filter() =
691691
// integer Seq
692692
let funcInt x = if (x % 5 = 0) then true else false
693693
let IntSeq =
@@ -726,7 +726,7 @@ type SeqModule() =
726726
()
727727

728728
[<Test>]
729-
member this.Find() =
729+
let Find() =
730730

731731
// integer Seq
732732
let funcInt x = if (x % 5 = 0) then true else false
@@ -755,7 +755,7 @@ type SeqModule() =
755755
()
756756

757757
[<Test>]
758-
member this.FindBack() =
758+
let FindBack() =
759759
// integer Seq
760760
let funcInt x = x % 5 = 0
761761
Assert.AreEqual(20, Seq.findBack funcInt <| seq { 1..20 })
@@ -782,7 +782,7 @@ type SeqModule() =
782782
()
783783

784784
[<Test>]
785-
member this.FindIndex() =
785+
let FindIndex() =
786786

787787
// integer Seq
788788
let digits = [1 .. 100] |> Seq.ofList
@@ -797,7 +797,7 @@ type SeqModule() =
797797
()
798798

799799
[<Test>]
800-
member this.Permute() =
800+
let Permute() =
801801
let mapIndex i = (i + 1) % 4
802802

803803
// integer seq
@@ -823,7 +823,7 @@ type SeqModule() =
823823
()
824824

825825
[<Test>]
826-
member this.FindIndexBack() =
826+
let FindIndexBack() =
827827
// integer Seq
828828
let digits = seq { 1..100 }
829829
let idx = digits |> Seq.findIndexBack (fun i -> i.ToString().Length = 1)
@@ -843,7 +843,7 @@ type SeqModule() =
843843
()
844844

845845
[<Test>]
846-
member this.Pick() =
846+
let Pick() =
847847

848848
let digits = [| 1 .. 10 |] |> Seq.ofArray
849849
let result = Seq.pick (fun i -> if i > 5 then Some(i.ToString()) else None) digits
@@ -857,7 +857,7 @@ type SeqModule() =
857857
()
858858

859859
[<Test>]
860-
member this.Fold() =
860+
let Fold() =
861861
let funcInt x y = x+y
862862

863863
let IntSeq =
@@ -889,7 +889,7 @@ type SeqModule() =
889889

890890

891891
[<Test>]
892-
member this.Fold2() =
892+
let Fold2() =
893893
Assert.AreEqual([(3,5); (2,3); (1,1)],Seq.fold2 (fun acc x y -> (x,y)::acc) [] (seq [ 1..3 ]) (seq [1..2..6]))
894894

895895
// integer List
@@ -921,7 +921,7 @@ type SeqModule() =
921921
()
922922

923923
[<Test>]
924-
member this.FoldBack() =
924+
let FoldBack() =
925925
// int Seq
926926
let funcInt x y = x-y
927927
let IntSeq = seq { 1..4 }
@@ -957,7 +957,7 @@ type SeqModule() =
957957
()
958958

959959
[<Test>]
960-
member this.foldBack2() =
960+
let foldBack2() =
961961
// int Seq
962962
let funcInt x y z = x + y + z
963963
let intSeq = seq { 1..10 }
@@ -996,7 +996,7 @@ type SeqModule() =
996996
()
997997

998998
[<Test>]
999-
member this.ForAll() =
999+
let ForAll() =
10001000

10011001
let funcInt x = if x%2 = 0 then true else false
10021002
let IntSeq =
@@ -1027,7 +1027,7 @@ type SeqModule() =
10271027
()
10281028

10291029
[<Test>]
1030-
member this.ForAll2() =
1030+
let ForAll2() =
10311031

10321032
let funcInt x y = if (x+y)%2 = 0 then true else false
10331033
let IntSeq =
@@ -1058,7 +1058,7 @@ type SeqModule() =
10581058
CheckThrowsArgumentNullException (fun () -> Seq.forall2 funcInt nullSeq nullSeq |> ignore)
10591059

10601060
[<Test>]
1061-
member this.GroupBy() =
1061+
let GroupBy() =
10621062

10631063
let funcInt x = x%5
10641064

@@ -1101,7 +1101,7 @@ type SeqModule() =
11011101
()
11021102

11031103
[<Test>]
1104-
member this.DisposalOfUnstartedEnumerator() =
1104+
let DisposalOfUnstartedEnumerator() =
11051105
let run = ref false
11061106
let f() = seq {
11071107
try
@@ -1114,7 +1114,7 @@ type SeqModule() =
11141114
Assert.IsFalse(!run)
11151115

11161116
[<Test>]
1117-
member this.WeirdLocalNames() =
1117+
let WeirdLocalNames() =
11181118

11191119
let f pc = seq {
11201120
yield pc
@@ -1135,7 +1135,7 @@ type SeqModule() =
11351135
Assert.AreEqual([6;7;8], l)
11361136

11371137
[<Test>]
1138-
member this.Contains() =
1138+
let Contains() =
11391139

11401140
// Integer Seq
11411141
let intSeq = seq { 0..9 }

0 commit comments

Comments
 (0)