Skip to content

Commit fc20f9e

Browse files
committed
Update OperatorsModuleDynamic.fs
1 parent c8056fb commit fc20f9e

File tree

1 file changed

+12
-45
lines changed

1 file changed

+12
-45
lines changed

tests/FSharp.Core.UnitTests/FSharp.Core/OperatorsModuleDynamic.fs

Lines changed: 12 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -98,10 +98,7 @@ module OperatorsModuleDynamic =
9898

9999
// Overflow
100100
let result = Operators.byte Single.MaxValue
101-
if not Info.isNetFramework then
102-
Assert.AreEqual(255uy, result)
103-
else
104-
Assert.AreEqual(0uy, result)
101+
Assert.AreEqual(0uy, result)
105102

106103
// Overflow
107104
let result = Operators.byte Double.MinValue
@@ -143,10 +140,7 @@ module OperatorsModuleDynamic =
143140
Assert.AreEqual('\000', Operators.char Single.MinValue)
144141
Assert.AreEqual('\000', Operators.char Double.MinValue)
145142

146-
if not Info.isNetFramework then
147-
Assert.AreEqual('\uffff', Operators.char Single.MaxValue)
148-
else
149-
Assert.AreEqual('\000', Operators.char Single.MaxValue)
143+
Assert.AreEqual('\000', Operators.char Single.MaxValue)
150144

151145
Assert.AreEqual('\000', Operators.char Double.MaxValue)
152146
CheckThrowsOverflowException(fun () -> Operators.char Decimal.MinValue |> ignore)
@@ -298,10 +292,7 @@ module OperatorsModuleDynamic =
298292

299293
// Overflow
300294
let result = Operators.int16 Single.MaxValue
301-
if not Info.isNetFramework then
302-
Assert.AreEqual(-1s, result)
303-
else
304-
Assert.AreEqual(0s, result)
295+
Assert.AreEqual(0s, result)
305296

306297
// Overflow
307298
let result = Operators.int16 Single.MinValue
@@ -353,10 +344,7 @@ module OperatorsModuleDynamic =
353344

354345
// Overflow
355346
let result = Operators.int32 Single.MaxValue
356-
if not Info.isNetFramework then
357-
Assert.AreEqual(Int32.MaxValue, result)
358-
else
359-
Assert.AreEqual(Int32.MinValue, result)
347+
Assert.AreEqual(Int32.MinValue, result)
360348

361349
// Overflow
362350
let result = Operators.int32 Single.MinValue
@@ -409,10 +397,7 @@ module OperatorsModuleDynamic =
409397

410398
// Overflow.
411399
let result = Operators.int64 Single.MaxValue
412-
if not Info.isNetFramework then
413-
Assert.AreEqual(Int64.MaxValue, result)
414-
else
415-
Assert.AreEqual(Int64.MinValue, result)
400+
Assert.AreEqual(Int64.MinValue, result)
416401

417402
// Overflow
418403
let result = Operators.int64 Single.MinValue
@@ -465,11 +450,8 @@ module OperatorsModuleDynamic =
465450
if Info.isX86Runtime then
466451
Assert.AreEqual(-2147483648n, result)
467452
else
468-
if not Info.isNetFramework then
469-
Assert.AreEqual(9223372036854775807n, result)
470-
else
471-
// Cannot use -9223372036854775808, compiler doesn't allow it, see https://github.com/dotnet/fsharp/issues/9524
472-
Assert.AreEqual(-9223372036854775807n - 1n, result)
453+
// Cannot use -9223372036854775808, compiler doesn't allow it, see https://github.com/dotnet/fsharp/issues/9524
454+
Assert.AreEqual(-9223372036854775807n - 1n, result)
473455

474456
// Overflow (depends on pointer size)
475457
let result = Operators.nativeint Single.MinValue
@@ -568,10 +550,7 @@ module OperatorsModuleDynamic =
568550

569551
// Overflow
570552
let result = Operators.sbyte Single.MaxValue
571-
if not Info.isNetFramework then
572-
Assert.AreEqual(-1y, result)
573-
else
574-
Assert.AreEqual(0y, result)
553+
Assert.AreEqual(0y, result)
575554

576555
// Overflow
577556
let result = Operators.sbyte Double.MinValue
@@ -623,10 +602,7 @@ module OperatorsModuleDynamic =
623602

624603
// Overflow
625604
let result = Operators.uint16 Single.MaxValue
626-
if not Info.isNetFramework then
627-
Assert.AreEqual(65535us, result)
628-
else
629-
Assert.AreEqual(0us, result)
605+
Assert.AreEqual(0us, result)
630606

631607
// Overflow
632608
let result = Operators.uint16 Single.MinValue
@@ -659,10 +635,7 @@ module OperatorsModuleDynamic =
659635

660636
// Overflow
661637
let result = Operators.uint32 Single.MaxValue
662-
if not Info.isNetFramework then
663-
Assert.AreEqual(4294967295u, result)
664-
else
665-
Assert.AreEqual(0u, result)
638+
Assert.AreEqual(0u, result)
666639

667640
// Overflow
668641
let result = Operators.uint32 Single.MinValue
@@ -712,10 +685,7 @@ module OperatorsModuleDynamic =
712685

713686
// Overflow
714687
let result = Operators.uint64 Single.MaxValue
715-
if not Info.isNetFramework then
716-
Assert.AreEqual(18446744073709551615UL, result)
717-
else
718-
Assert.AreEqual(0UL, result)
688+
Assert.AreEqual(0UL, result)
719689

720690
// Overflow
721691
let result = Operators.uint64 Single.MinValue
@@ -757,10 +727,7 @@ module OperatorsModuleDynamic =
757727

758728
// Overflow Single.MaxValue is equal on 32 bits and 64 bits runtimes
759729
let result = Operators.unativeint Single.MaxValue
760-
if not Info.isNetFramework then
761-
Assert.AreEqual(18446744073709551615un, result)
762-
else
763-
Assert.AreEqual(0un, result)
730+
Assert.AreEqual(0un, result)
764731

765732
// Overflow (depends on pointer size)
766733
let result = Operators.unativeint Single.MinValue

0 commit comments

Comments
 (0)