Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate FSharpQA suite to xUnit suite(s) #10001

Closed
vzarytovskii opened this issue Aug 25, 2020 · 5 comments
Closed

Migrate FSharpQA suite to xUnit suite(s) #10001

vzarytovskii opened this issue Aug 25, 2020 · 5 comments
Labels
Area-Testing Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code.

Comments

@vzarytovskii
Copy link
Member

vzarytovskii commented Aug 25, 2020

We want to migrate FSharpQA tests from a custom runner/solution to a standard dotnet test project(s).

  • Tests have to be migrated to one of following:
    • FSharp.Compiler.ComponentTests - if it's a "blackbox"-style test for the compiler, when we want to check compiler output itself, e.g. IL generation, compiler errors and warnings tests, conformance tests, etc.
    • FSharp.Compiler.UnitTests - if it's a test for a compiler "API".
    • FSharp.Core.UnitTests - if it's a test for library functions.

Prerequisite: #10000

@dsyme
Copy link
Contributor

dsyme commented Aug 26, 2020

FSharp.Compiler.ComponentTests - if it's a "blackbox"-style test for the compiler, when we want to check compiler output itself, e.g. IL generation, compiler errors and warnings tests, conformance tests, etc.

FSharp.Compiler.UnitTests - if it's a test for a compiler "API".

I find these names a bit confusing ComponentTests sounds like Unit Tests to me.

Maybe aim for this:

  • FSharp.Core.UnitTests // tests for FSharp.Core

  • FSharp.Compiler.UnitTests // unit tests for FSharp.Compiler and FSharp.Compiler.Service

  • FSharp.Compiler.UsageTests // tests actual usage of language and tools

  • VisualFSharp....UnitTests // tests for anything involving Visual Studio, Roslyn

So basically rename "ComponentTests" to "UsageTests"

@vzarytovskii
Copy link
Member Author

I find these names a bit confusing ComponentTests sounds like Unit Tests to me.

My idea was that we test compiler as an "external", separate "component", hence the category "ComponentTests".

We already have this project, renaming it should be easy though.

@cartermp
Copy link
Contributor

Should "UsageTests" just be "LanguageTests"? Since that's basically what they are. Tooling tests would go under relevant tooling subfolders anyways

@vzarytovskii
Copy link
Member Author

Should "UsageTests" just be "LanguageTests"? Since that's basically what they are. Tooling tests would go under relevant tooling subfolders anyways

Keep in mind, that currently, there are not only "Language" tests there, but also stuff like IL verification, Interop, I guess if it falls under "LanguageTests", then I guess, we can have it as "LanguageTests"

@KevinRansom KevinRansom added the Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code. label Jul 21, 2021
@dsyme dsyme changed the title [Test Framework] Cambridge/FSharpQA tests need to be migrated to xUnit suite(s) Migrate FSharpQA suite to xUnit suite(s) Apr 20, 2022
@dsyme
Copy link
Contributor

dsyme commented Apr 20, 2022

Now covered by #12823

@dsyme dsyme closed this as completed Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Testing Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code.
Projects
None yet
Development

No branches or pull requests

4 participants